Page MenuHomeFreeBSD
Differential D9239

Misc Coverity fixes in camcontrol(8)
ClosedPublic
Actions

Authored by asomers on Jan 19 2017, 12:37 AM.
Tags
None
Referenced Files
F120224308: D9239.diff
Mon, Jun 16, 5:18 AM
Unknown Object (File)
Sun, Jun 1, 4:07 AM
Unknown Object (File)
Tue, May 20, 5:29 AM
Unknown Object (File)
May 1 2025, 7:50 PM
Unknown Object (File)
Apr 25 2025, 4:08 PM
Unknown Object (File)
Apr 24 2025, 3:12 AM
Unknown Object (File)
Apr 24 2025, 3:12 AM
Unknown Object (File)
Apr 24 2025, 3:12 AM
View All 67 Files
Subscribers
imp
wblock

Details

Reviewers
ken
Group Reviewers
manpages
Commits
rS317374: MFC r312558:
rS312558: Misc Coverity fixes in camcontrol(8)
Summary

Misc Coverity fixes in camcontrol(8)

CID 1229913 Fix output of "camcontrol persist -i report_capabilities".

		The reported Persistent Reservation Types are currently wrong
		in all cases.

CID 1356029 Annotate the code so Coverity will know that this is a false

		positive.

CID 1366830 Fix a memory leak
CID 1366832 Fix a segfault that could be caused by bad drive firmware

Also, fix the man page entry for the "camcontrol epc state" command to match
what the code does.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 24178.Jan 19 2017, 12:37 AM
asomers retitled this revision from to Misc Coverity fixes in camcontrol(8).
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: ken.
Herald added a reviewer: manpages. · View Herald TranscriptJan 19 2017, 12:37 AM
Herald added a subscriber: imp. · View Herald Transcript
ken accepted this revision.Jan 19 2017, 9:30 PM
ken edited edge metadata.

Looks good, thank you!

This revision is now accepted and ready to land.Jan 19 2017, 9:30 PM
wblock added a subscriber: wblock.Jan 20 2017, 4:28 PM
wblock added inline comments.
sbin/camcontrol/camcontrol.8
2386 ↗(On Diff #24178)

"Either" reads a bit better.

wblock added a comment.Jan 20 2017, 4:28 PM

Please remember to bump .Dd, too. Thanks!

asomers added inline comments.Jan 20 2017, 5:45 PM
sbin/camcontrol/camcontrol.8
2386 ↗(On Diff #24178)

To me, "either" suggests an OR relationship. But in this case, the two options have an XOR relationship. So I prefer "One of" in this case.

wblock added inline comments.Jan 20 2017, 9:07 PM
sbin/camcontrol/camcontrol.8
2386 ↗(On Diff #24178)

"Either A or B" is the way exclusive or is generally stated in English but I understand the point. Thanks!

Closed by commit rS312558: Misc Coverity fixes in camcontrol(8) (authored by asomers). · Explain WhyJan 20 2017, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
camcontrol/
16 lines
1 line
14 lines
4 lines

Diff 24252

View Options

head/sbin/camcontrol/camcontrol.8

Loading...
View Options

head/sbin/camcontrol/epc.c

Loading...
View Options

head/sbin/camcontrol/persist.c

Loading...
View Options

head/sbin/camcontrol/timestamp.c

Loading...