Page MenuHomeFreeBSD
Feed Advanced Search

Aug 12 2020

avg committed rS364144: add a manual page for cp2112.
add a manual page for cp2112
Aug 12 2020, 9:42 AM
avg committed rS364143: cp2112: a number of cleanups and improvements.
cp2112: a number of cleanups and improvements
Aug 12 2020, 9:07 AM

Aug 6 2020

avg committed rS363951: cp2112: driver for the namesake GPIO and I2C master gadget.
cp2112: driver for the namesake GPIO and I2C master gadget
Aug 6 2020, 1:42 PM
avg closed D25359: cp2112: driver for the namesake GPIO and I2C master gadget.
Aug 6 2020, 1:42 PM
avg retitled D25359: cp2112: driver for the namesake GPIO and I2C master gadget from [DRAFT] cp2112: driver for the namesake GPIO and I2C master gadget to cp2112: driver for the namesake GPIO and I2C master gadget.
Aug 6 2020, 1:14 PM
avg added a comment to D25359: cp2112: driver for the namesake GPIO and I2C master gadget.

@adrian , @hselasky , thank you very much for the reviews!
I will do some improvements right now, but will leave others for a later time (hopefully soon).

Aug 6 2020, 1:12 PM
avg abandoned D25360: [DRAFT] cp2112: driver for the namesake GPIO and I2C master gadget.

Abandon in favor of D25359

Aug 6 2020, 11:52 AM
avg committed rS363948: ccu_sun8i_r: minor comment update.
ccu_sun8i_r: minor comment update
Aug 6 2020, 11:18 AM
avg updated the diff for D25940: gpiokeys: first take at evdev support.

address some of the comments

Aug 6 2020, 11:13 AM
avg added a comment to D25940: gpiokeys: first take at evdev support.

Thank you all for the reviews and suggestions.

Aug 6 2020, 10:43 AM
avg committed rS363944: MFC r362042: iicbb: rebuild the bit-banging algorithms using different….
MFC r362042: iicbb: rebuild the bit-banging algorithms using different…
Aug 6 2020, 8:06 AM

Aug 5 2020

avg committed rS363905: gpiokeys: add a basic manual page.
gpiokeys: add a basic manual page
Aug 5 2020, 11:38 AM
avg closed D25939: gpiokeys: add a basic manual page.
Aug 5 2020, 11:38 AM

Aug 4 2020

avg updated the diff for D25939: gpiokeys: add a basic manual page.

I misunderstood the code: "name" property is used to get the node name
if "label" property is not set.

Aug 4 2020, 10:12 AM
avg added inline comments to D25939: gpiokeys: add a basic manual page.
Aug 4 2020, 9:29 AM
avg updated the diff for D25939: gpiokeys: add a basic manual page.

s/FDT/DTS/ for clarity

Aug 4 2020, 9:26 AM
avg added inline comments to D25939: gpiokeys: add a basic manual page.
Aug 4 2020, 9:24 AM
avg added a comment to D25940: gpiokeys: first take at evdev support.

Good point!
The current code creates a device per each button, that is, a child node.

Aug 4 2020, 9:19 AM
avg updated the diff for D25939: gpiokeys: add a basic manual page.

address reviews and complaints from mandoc -Tlint

Aug 4 2020, 6:59 AM
avg added inline comments to D25939: gpiokeys: add a basic manual page.
Aug 4 2020, 6:58 AM
avg added a comment to D25939: gpiokeys: add a basic manual page.

Thank you for the reviews!
igor was happy, but mandoc complained about the order of cross-references.

Aug 4 2020, 6:57 AM
avg requested review of D25940: gpiokeys: first take at evdev support.
Aug 4 2020, 6:27 AM
avg requested review of D25939: gpiokeys: add a basic manual page.
Aug 4 2020, 6:22 AM

Aug 3 2020

avg committed rS363787: MFC r363597: actually enable gate control for allwinner's r-ccu ir clock.
MFC r363597: actually enable gate control for allwinner's r-ccu ir clock
Aug 3 2020, 6:10 AM

Jul 30 2020

avg committed rS363697: MFC r363383: dtrace/fbt: fix return probe arguments on arm.
MFC r363383: dtrace/fbt: fix return probe arguments on arm
Jul 30 2020, 2:05 PM
avg committed rS363696: MFC r363382: gpioiic: never drive lines active high.
MFC r363382: gpioiic: never drive lines active high
Jul 30 2020, 2:02 PM
avg committed rS363695: MFC r363232: build DTS for Orange Pi PC Plus as well.
MFC r363232: build DTS for Orange Pi PC Plus as well
Jul 30 2020, 1:56 PM
avg committed rS363694: MFC r362530: teach ena driver about RSS kernel option.
MFC r362530: teach ena driver about RSS kernel option
Jul 30 2020, 1:55 PM
avg committed rS363691: MFC r362492: gpiobus_release_pin: remove incorrect prefix from error messages.
MFC r362492: gpiobus_release_pin: remove incorrect prefix from error messages
Jul 30 2020, 1:17 PM
avg committed rS363690: MFC r362294,r362647: hdac_intr_handler: keep working until global interrupt….
MFC r362294,r362647: hdac_intr_handler: keep working until global interrupt…
Jul 30 2020, 12:59 PM

Jul 27 2020

avg committed rS363597: actually enable gate control for allwinner's r-ccu ir clock.
actually enable gate control for allwinner's r-ccu ir clock
Jul 27 2020, 9:10 AM

Jul 21 2020

avg committed rS363384: MFC r340450,r340664,r346176 by imp: fix time conversions to and from sbt.
MFC r340450,r340664,r346176 by imp: fix time conversions to and from sbt
Jul 21 2020, 7:58 AM
avg committed rS363383: dtrace/fbt: fix return probe arguments on arm.
dtrace/fbt: fix return probe arguments on arm
Jul 21 2020, 7:41 AM
avg closed D25685: dtrace/fbt: fix return probe arguments on arm.
Jul 21 2020, 7:41 AM
avg committed rS363382: gpioiic: never drive lines active high.
gpioiic: never drive lines active high
Jul 21 2020, 7:35 AM
avg closed D25684: gpioiic: never drive lines active high.
Jul 21 2020, 7:35 AM

Jul 20 2020

Herald added a reviewer for D12467: Add sdio(4) peripheral device: cam.
Jul 20 2020, 9:08 AM

Jul 16 2020

avg updated the summary of D25684: gpioiic: never drive lines active high.
Jul 16 2020, 11:08 AM
avg requested review of D25685: dtrace/fbt: fix return probe arguments on arm.
Jul 16 2020, 11:06 AM
avg added a comment to D25684: gpioiic: never drive lines active high.

Also, I think that it did not make much sense to preset a pin to low before re-configuring it as output.
If the pin's initial state would be low then the preset was a NOP.
If the pin's initial state would be high, then that should be not an issue as its previous state would be kept just a for bit longer before we changed it to low.
But not sure.

Jul 16 2020, 8:30 AM
avg requested review of D25684: gpioiic: never drive lines active high.
Jul 16 2020, 8:26 AM

Jul 15 2020

avg committed rS363232: build DTS for Orange Pi PC Plus as well.
build DTS for Orange Pi PC Plus as well
Jul 15 2020, 6:04 PM

Jul 2 2020

avg accepted D25543: Fix page fault in zfsctl_snapdir_getattr.

Thank you!

Jul 2 2020, 5:12 AM

Jun 27 2020

avg added a comment to D25487: kern.tty_info_kstacks: add a compact format.

I agree with both @mjg 's suggestions.

Jun 27 2020, 2:15 PM

Jun 26 2020

avg committed rS362647: sound/hda: fix interrupt handler endless loop after r362294.
sound/hda: fix interrupt handler endless loop after r362294
Jun 26 2020, 9:46 AM
avg committed rS362645: ena: fix module build after r362530.
ena: fix module build after r362530
Jun 26 2020, 9:33 AM

Jun 23 2020

avg closed D24733: teach ena driver about RSS kernel option.
Jun 23 2020, 4:58 AM
avg committed rS362530: teach ena driver about RSS kernel option.
teach ena driver about RSS kernel option
Jun 23 2020, 4:58 AM
avg requested review of D24779: linuxkpi: print stack trace in WARN_ON macros.
Jun 23 2020, 3:23 AM
avg closed D24779: linuxkpi: print stack trace in WARN_ON macros.
Jun 23 2020, 3:17 AM

Jun 22 2020

avg added inline comments to D25389: Add loop visualization and parallel execution support into rcorder.
Jun 22 2020, 8:52 PM
avg updated subscribers of D25389: Add loop visualization and parallel execution support into rcorder.

I'm a little late to the party, but thanks for the GraphViz! IIRC, I wrote a little shell script several years ago to pipe through to do the same thing, but I never committed it.

Jun 22 2020, 8:44 PM
avg committed rS362492: gpiobus_release_pin: remove incorrect prefix from error messages.
gpiobus_release_pin: remove incorrect prefix from error messages
Jun 22 2020, 10:32 AM

Jun 19 2020

avg requested review of D25360: [DRAFT] cp2112: driver for the namesake GPIO and I2C master gadget.
Jun 19 2020, 2:10 PM
avg updated the diff for D25359: cp2112: driver for the namesake GPIO and I2C master gadget.

add a couple of missing changes

Jun 19 2020, 2:02 PM
avg requested review of D25359: cp2112: driver for the namesake GPIO and I2C master gadget.
Jun 19 2020, 1:55 PM

Jun 18 2020

avg closed D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 18 2020, 9:20 AM
avg committed rS362294: hdac_intr_handler: keep working until global interrupt status clears.
hdac_intr_handler: keep working until global interrupt status clears
Jun 18 2020, 9:20 AM

Jun 17 2020

avg awarded D25312: Relax the rule against declaring variables in nested scopes. a Like token.
Jun 17 2020, 5:36 AM

Jun 12 2020

avg committed rS362088: fix up r362086, MFC of r361620, add missing VOP_UNLOCK argument.
fix up r362086, MFC of r361620, add missing VOP_UNLOCK argument
Jun 12 2020, 7:36 AM
avg committed rS362087: MFC r361621: do not enable pci bridge decoding on resume until I/O windows are….
MFC r361621: do not enable pci bridge decoding on resume until I/O windows are…
Jun 12 2020, 7:25 AM
avg committed rS362086: MFC r361620: corefile_open_last: don't keep a locked vnode while locking other….
MFC r361620: corefile_open_last: don't keep a locked vnode while locking other…
Jun 12 2020, 7:23 AM

Jun 11 2020

avg committed rS362048: fix up r362047: a call to zvol_*_minors() was not hidden from userland.
fix up r362047: a call to zvol_*_minors() was not hidden from userland
Jun 11 2020, 11:35 AM
avg closed D23478: rework how ZVOLs are updated in response to DSL operations.
Jun 11 2020, 10:42 AM
avg committed rS362047: rework how ZVOLs are updated in response to DSL operations.
rework how ZVOLs are updated in response to DSL operations
Jun 11 2020, 10:42 AM
avg committed rS362042: iicbb: rebuild the bit-banging algorithms using different primitives.
iicbb: rebuild the bit-banging algorithms using different primitives
Jun 11 2020, 5:34 AM
avg closed D22206: iicbb: rebuild the bit-banging algorithms using different primitives.
Jun 11 2020, 5:34 AM
avg committed rS362041: MFC r361788: superio: do not assume that current LDN cannot change after config….
MFC r361788: superio: do not assume that current LDN cannot change after config…
Jun 11 2020, 5:28 AM
avg committed rS362040: MFC r361787: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
MFC r361787: ifconfig.8: fix cpability and flag descriptions for list scan / sta
Jun 11 2020, 5:26 AM

Jun 5 2020

avg committed rS361824: fix up r361823, libprocstat zfs support, on powerpc.
fix up r361823, libprocstat zfs support, on powerpc
Jun 5 2020, 7:38 AM
avg committed rS361823: MFC r361363,r361434: libprocstat: fix ZFS support.
MFC r361363,r361434: libprocstat: fix ZFS support
Jun 5 2020, 6:34 AM

Jun 4 2020

avg added inline comments to D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 4 2020, 1:58 PM
avg added inline comments to D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 4 2020, 1:46 PM
avg committed rS361788: superio: do not assume that current LDN cannot change after config exit.
superio: do not assume that current LDN cannot change after config exit
Jun 4 2020, 1:18 PM
avg closed D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
Jun 4 2020, 1:07 PM
avg committed rS361787: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
ifconfig.8: fix cpability and flag descriptions for list scan / sta
Jun 4 2020, 1:07 PM
avg committed rS361786: MFC r361273: iwm: improve rfkill handling.
MFC r361273: iwm: improve rfkill handling
Jun 4 2020, 1:03 PM
avg updated the summary of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 4 2020, 7:09 AM
avg updated the summary of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 4 2020, 7:03 AM
avg requested review of D25128: hdac_intr_handler: keep working until global interrupt status clears.
Jun 4 2020, 7:00 AM
avg added inline comments to D17772: Add hack to allow users to bypass pin widget initialization..
Jun 4 2020, 6:55 AM
avg added a comment to D17772: Add hack to allow users to bypass pin widget initialization..

This is probably completely wrong on multiple levels, but this certainly does allow me to use my headphones again on my Skylake Intel HDA box.

sysctl.conf:dev.hdaa.0.init_clear=0

Jun 4 2020, 6:54 AM

Jun 2 2020

avg added a comment to D24989: netinet: Generate a random RSS key on boot..
In D24989#552693, @neel_neelc.org wrote:
Jun 2 2020, 8:30 AM · csprng, network

Jun 1 2020

avg added a comment to D24989: netinet: Generate a random RSS key on boot..

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Jun 1 2020, 10:17 AM · csprng, network

May 29 2020

avg closed D25028: do not enable pci bridge decoding on resume until I/O windows are restored.
May 29 2020, 7:51 AM
avg committed rS361621: do not enable pci bridge decoding on resume until I/O windows are restored.
do not enable pci bridge decoding on resume until I/O windows are restored
May 29 2020, 7:51 AM
avg closed D25027: corefile_open_last: don't keep a locked vnode while locking other ones.
May 29 2020, 7:44 AM
avg committed rS361620: corefile_open_last: don't keep a locked vnode while locking other ones.
corefile_open_last: don't keep a locked vnode while locking other ones
May 29 2020, 7:44 AM
avg committed rS361619: MFC r361364: net80211: post RTM_IFINFO notification after toggling….
MFC r361364: net80211: post RTM_IFINFO notification after toggling…
May 29 2020, 7:39 AM
avg committed rS361618: MFC r361330: libprocstat: fix reading of file descriptor table via kvm.
MFC r361330: libprocstat: fix reading of file descriptor table via kvm
May 29 2020, 7:37 AM

May 28 2020

avg added a comment to D25028: do not enable pci bridge decoding on resume until I/O windows are restored.

John, I know that you would prefer something grander.
Do you at least not object to this change ?

May 28 2020, 7:02 PM

May 27 2020

avg requested review of D25028: do not enable pci bridge decoding on resume until I/O windows are restored.
May 27 2020, 1:02 PM
avg added a comment to D25027: corefile_open_last: don't keep a locked vnode while locking other ones.

Just in case:

(kgdb) tid 101533
(kgdb) bt
#0  sched_switch (td=0xfffffe00b4f85500, flags=<optimized out>) at /usr/devel/git/motil/sys/kern/sched_ule.c:2147
#1  0xffffffff807e4de2 in mi_switch (flags=260) at /usr/devel/git/motil/sys/kern/kern_synch.c:542
#2  0xffffffff80831916 in sleepq_switch (wchan=0xfffff80085627bd8, pri=<optimized out>) at /usr/devel/git/motil/sys/kern/subr_sleepqueue.c:625
#3  0xffffffff807acb61 in sleeplk (lk=0xfffff80085627bd8, flags=532480, ilk=<optimized out>, wmesg=<optimized out>, pri=<optimized out>, timo=51, queue=0) at /usr/devel/git/motil/sys/kern/kern_lock.c:295
#4  0xffffffff807ab19f in lockmgr_xlock_hard (lk=0xfffff80085627bd8, flags=<unavailable>, ilk=0x0, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438, 
    lwa=0xfffff80085627bd8) at /usr/devel/git/motil/sys/kern/kern_lock.c:841
#5  0xffffffff808c3c64 in VOP_LOCK1 (vp=0xfffff80085627b70, flags=532480, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438) at ./vnode_if.h:879
#6  _vn_lock (vp=0xfffff80085627b70, flags=532480, file=0xffffffff80c40f02 "/usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c", line=1438) at /usr/devel/git/motil/sys/kern/vfs_vnops.c:1613
#7  0xffffffff8045ef27 in zfs_lookup_lock (dvp=0xfffff8000bc1c5b8, vp=0xfffff80085627b70, name=0xfffffe00b07cb3b0 "kcminit.1001.00.core", lkflags=532480)
    at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:1438
#8  zfs_lookup (dvp=<optimized out>, nm=0xfffffe00b07cb3b0 "kcminit.1001.00.core", vpp=<optimized out>, cnp=0xfffffe00b07cb8a0, nameiop=1, cr=<optimized out>, td=<optimized out>, flags=0, cached=1)
    at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:1612
#9  0xffffffff8045f60d in zfs_freebsd_lookup (ap=0xfffffe00b07cb4e0, cached=<error reading variable: Cannot access memory at address 0x1>) at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:4922
#10 zfs_freebsd_cachedlookup (ap=0xfffffe00b07cb4e0) at /usr/devel/git/motil/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:4930
#11 0xffffffff80898248 in VOP_CACHEDLOOKUP (dvp=0xfffff8000bc1c5b8, vpp=0xfffffe00b07cb870, cnp=0xfffffe00b07cb8a0) at ./vnode_if.h:80
#12 vfs_cache_lookup (ap=<optimized out>) at /usr/devel/git/motil/sys/kern/vfs_cache.c:2149
#13 0xffffffff808a22c1 in VOP_LOOKUP (dvp=0xfffff8000bc1c5b8, vpp=0xfffffe00b07cb870, cnp=0xfffffe00b07cb8a0) at ./vnode_if.h:54
#14 lookup (ndp=0xfffffe00b07cb810) at /usr/devel/git/motil/sys/kern/vfs_lookup.c:951
#15 0xffffffff808a17f3 in namei (ndp=0xfffffe00b07cb810) at /usr/devel/git/motil/sys/kern/vfs_lookup.c:512
#16 0xffffffff808c314b in vn_open_cred (ndp=0xfffffe00b07cb810, flagp=0xfffffe00b07cba4c, cmode=384, vn_open_flags=5, cred=0xfffff801edb7a000, fp=0x0) at /usr/devel/git/motil/sys/kern/vfs_vnops.c:226
#17 0xffffffff807dcec4 in corefile_open_last (td=<optimized out>, name=<optimized out>, indexpos=<optimized out>, indexlen=<optimized out>, ncores=<optimized out>, vpp=<optimized out>)
    at /usr/devel/git/motil/sys/kern/kern_sig.c:3434
#18 corefile_open (comm=0xfffff80013c098f0 "kcminit", uid=<optimized out>, pid=<optimized out>, td=0xfffffe00b4f85500, compress=0, signum=5, vpp=<optimized out>, namep=<optimized out>)
    at /usr/devel/git/motil/sys/kern/kern_sig.c:3585
#19 coredump (td=0xfffffe00b4f85500) at /usr/devel/git/motil/sys/kern/kern_sig.c:3669
#20 sigexit (td=0xfffffe00b4f85500, sig=6) at /usr/devel/git/motil/sys/kern/kern_sig.c:3211
#21 0xffffffff807ddc3c in postsig (sig=6) at /usr/devel/git/motil/sys/kern/kern_sig.c:3109
#22 0xffffffff8083969b in ast (framep=0xfffffe00b07cbc00) at /usr/devel/git/motil/sys/kern/subr_trap.c:336
May 27 2020, 12:42 PM
avg requested review of D25027: corefile_open_last: don't keep a locked vnode while locking other ones.
May 27 2020, 12:35 PM

May 26 2020

avg updated the diff for D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.

fix a typo

May 26 2020, 9:05 AM
avg added a comment to D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.

Some of the new description can use additional explanation, but I am not sufficiently fluent with WiFi concepts to do that.

May 26 2020, 9:03 AM
avg requested review of D25014: ifconfig.8: fix cpability and flag descriptions for list scan / sta.
May 26 2020, 9:00 AM
avg committed rS361496: MFC r360956: zfs allow/unallow should work with numeric uid/gid.
MFC r360956: zfs allow/unallow should work with numeric uid/gid
May 26 2020, 5:56 AM
avg committed rS361495: MFC r360657: acpi_video: support systems without non-essential methods.
MFC r360657: acpi_video: support systems without non-essential methods
May 26 2020, 5:54 AM

May 24 2020

avg committed rS361434: libprocstat: try to fix fallout from r361363.
libprocstat: try to fix fallout from r361363
May 24 2020, 2:54 PM