cp2112: driver for the namesake GPIO and I2C master gadget
ClosedPublic
Actions

Authored by avg on Jun 19 2020, 1:55 PM.

Details

Reviewers

• hselasky
adrian

Commits

rS363951: cp2112: driver for the namesake GPIO and I2C master gadget

Summary

Documentation:

CP2112 Datasheet https://www.silabs.com/documents/public/data-sheets/cp2112-datasheet.pdf
AN495: CP2112 Interface Specification https://www.silabs.com/documents/public/application-notes/an495-cp2112-interface-specification.pdf
CP2112 Errata https://www.silabs.com/documents/public/errata/cp2112-errata.pdf

The logic is implemented as three sub-drivers.
The parent driver claims the USB device and creates two child devices,
one acts as a GPIO controller and the other is an I2C controller.

Test Plan

Tested with CP2112 F02.
Both features seem to work.
HTU21 is used as an I2C slave.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avg created this revision.Jun 19 2020, 1:55 PM

Herald added subscribers: loos, imp. · View Herald TranscriptJun 19 2020, 1:55 PM

avg requested review of this revision.Jun 19 2020, 1:55 PM

Harbormaster completed remote builds in B31826: Diff 73334.Jun 19 2020, 1:55 PM

add a couple of missing changes

Harbormaster completed remote builds in B31827: Diff 73335.Jun 19 2020, 2:02 PM

avg mentioned this in D25360: [DRAFT] cp2112: driver for the namesake GPIO and I2C master gadget.Jun 19 2020, 2:10 PM

the GPIO/i2c bits at first glance look ok.

This revision is now accepted and ready to land.Jul 14 2020, 6:15 AM

adrian added inline comments.Jul 14 2020, 6:17 AM

sys/dev/usb/misc/cp2112.c
1073 ↗	(On Diff #73335)	Maybe add some defines for these magic constant lengths? Describing what they are.
1136 ↗	(On Diff #73335)	.. same with this one. is the 16 byte limit used elsewhere?

Should also add a build rule to sys/conf/files .

sys/dev/usb/misc/cp2112.c
430 ↗	(On Diff #73335)	Nice if vendor 0x1009 could be added to usbdevs. If not known, then just leave it.

@adrian , @hselasky , thank you very much for the reviews!
I will do some improvements right now, but will leave others for a later time (hopefully soon).

avg retitled this revision from [DRAFT] cp2112: driver for the namesake GPIO and I2C master gadget to cp2112: driver for the namesake GPIO and I2C master gadget.Aug 6 2020, 1:14 PM

Closed by commit rS363951: cp2112: driver for the namesake GPIO and I2C master gadget (authored by avg). · Explain WhyAug 6 2020, 1:42 PM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rS363951: cp2112: driver for the namesake GPIO and I2C master gadget.