Page MenuHomeFreeBSD

dtrace/fbt: fix return probe arguments on arm
ClosedPublic

Authored by avg on Jul 16 2020, 11:06 AM.

Details

Summary

arg0 should be offset of the return point within the function,
arg1 should be the return value.
Previously a return probe had arguments as if for an entry probe.

Test Plan

Tested on armv7.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avg requested review of this revision.Jul 16 2020, 11:06 AM

It looks like arm64, mips, and riscv share this problem. It might pay to fix them all at the same time.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2020, 7:41 AM
This revision was automatically updated to reflect the committed changes.