Paths

Table of Contentst

dtrace/fbt: fix return probe arguments on arm
ClosedPublic
Actions

Authored by avg on Jul 16 2020, 11:06 AM.

Details

Reviewers

andrew
• ian
markj
gnn

Commits

rS363383: dtrace/fbt: fix return probe arguments on arm

Summary

arg0 should be offset of the return point within the function,
arg1 should be the return value.
Previously a return probe had arguments as if for an entry probe.

Test Plan

Tested on armv7.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avg created this revision.Jul 16 2020, 11:06 AM

Herald added a reviewer: gnn. · View Herald TranscriptJul 16 2020, 11:06 AM

Herald added a subscriber: imp. · View Herald Transcript

avg requested review of this revision.Jul 16 2020, 11:06 AM

Harbormaster completed remote builds in B32357: Diff 74516.Jul 16 2020, 11:06 AM

markj accepted this revision.Jul 16 2020, 1:25 PM

It looks like arm64, mips, and riscv share this problem. It might pay to fix them all at the same time.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2020, 7:41 AM

Closed by commit rS363383: dtrace/fbt: fix return probe arguments on arm (authored by avg). · Explain Why

This revision was automatically updated to reflect the committed changes.

avg added a commit: rS363383: dtrace/fbt: fix return probe arguments on arm.

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

dev/

dtrace/

arm/

dtrace_subr.c

2 lines

fbt/

arm/

fbt_isa.c

18 lines

Diff 74731

View Options

head/sys/cddl/dev/dtrace/arm/dtrace_subr.c