Oh wow ... time flies. I've now been "testing" this patch for over two years. We should just do this.

Looks good! Just one very minor nit.

I wonder if this wants some abstraction in the form of a function rather than chasing every str*cpy...?

Replace a couple more "being made" with "being established".

Addressed suggestions from gbe.

In D30183#704231, @trasz wrote:

Now, about the upstream - I've looked at https://github.com/eggert/tz.git, and it... well, it does resemble our code, to an extent. Which is to say, their code is quite a bit different from ours. Not sure how to handle this, tbh.

Should this be upstreamed? Our tcpdump isn't far behind upstream. Merging a newer upstream is pretty straightforward too.

In D31025#698503, @jrtc27 wrote:

In D31025#698167, @philip wrote:

This changes looks good to me. Though I agree with your observation that we should consider moving away from rxready. I wonder why we never noticed this on the FU540. Did this change?

It doesn't affect normal serial console use as that uses the uart methods, it's only for the low-level console, i.e. ddb, which includes mountroot, so I assume nobody ever tried to use it with those (or did and never bothered fixing it).

This changes looks good to me. Though I agree with your observation that we should consider moving away from rxready. I wonder why we never noticed this on the FU540. Did this change?

Thank you! This looks good.

I have been running with this change on my access points at home and at my local hackerspace for a while. It seems to work fine.

Looks good to me. Let's see if it works. :)

@imp Weekly? There were six releases of tzdata in all of 2020...

@rscheff They are not downloaded automatically. That would make it impossible to build world/universe on an offline machine. They are imported when a new tzdb release is made. I've been doing this for the past several years. I actively follow the tz mailing list. Releases of tzdata are usually imported into FreeBSD head within days of the upstream release (often hours). Imports are merged to stable/* branches soon after and we issue errata notices for supported releases not much later.

Is this NetApp code being merged, or is this upstream tzcode? If this is not upstream, it should be submitted to the tz mailing list for wider review by the tz community.

Looks good to me!

This compiles and runs in my tests. Thanks very much!

Approved by: philip (mentor)

Approved by: philip (mentor)

Approved by: philip (mentor)

Great! Thank you.

Approved by: philip (mentor)

Looks good to me.

Approved by: philip (mentor)

Approved by: philip (mentor)

A couple of very minor style nits left. Functionally looks good.

Approved by: philip (mentor)

Approved by: philip (mentor)

Approved by: philip (mentor)

I agree with @manu that it's a bit weird to see list.h include net/ headers (and I expect bde is spinning in his grave) but at this stage, I can't see a better way forward. @bz's suggestion to rename the macro would make it more work to use the LinuxKPI. That would be a step backwards.

The "originally by" should probably be spelled "Submitted by".

Awesome. Thank you!

Approved by: philip (mentor)