last: improve non-UTF8 locale output after libxo support was added
ClosedPublic
Actions

Authored by pstef on Oct 10 2021, 7:20 AM.

Tags

None

Referenced Files

	F162957881: D32437.id96594.diff
	Sat, Jul 18, 4:59 PM

	Unknown Object (File)
	Sat, Jul 18, 4:05 PM

	Unknown Object (File)
	Mon, Jul 6, 1:17 PM

	Unknown Object (File)
	Mon, Jul 6, 3:42 AM

	Unknown Object (File)
	Sun, Jun 28, 12:09 AM

	Unknown Object (File)
	Fri, Jun 26, 10:39 PM

	Unknown Object (File)
	May 29 2026, 11:07 PM

	Unknown Object (File)
	May 29 2026, 8:59 PM

View All Files

Subscribers

imp

Details

Reviewers

philip
eugen_grosbein.net

Commits

rG902cde5d0a62: Revert "last(1): unbreak for 8-bit locales"
rG8da27052535b: last: improve non-UTF8 locale output after libxo support was added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pstef requested review of this revision.Oct 10 2021, 7:20 AM

pstef created this revision.

Looks good! Just one very minor nit.

usr.bin/last/last.c
396	This one can be %s. strftime(%R) does not change with locale.

This revision is now accepted and ready to land.Oct 11 2021, 2:51 AM

eugen_grosbein.net accepted this revision.Oct 11 2021, 4:39 AM

Closed by commit rG8da27052535b: last: improve non-UTF8 locale output after libxo support was added (authored by pstef). · Explain WhyOct 11 2021, 5:05 PM

This revision was automatically updated to reflect the committed changes.

pstef added a commit: rG8da27052535b: last: improve non-UTF8 locale output after libxo support was added.

Herald added a subscriber: imp. · View Herald TranscriptOct 11 2021, 5:05 PM

pstef added a commit: rG902cde5d0a62: Revert "last(1): unbreak for 8-bit locales".Oct 11 2021, 5:05 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

last/

last.c

4 lines

Diff 96682

View Options

last: improve non-UTF8 locale output after libxo support was addedClosedPublicActions