Page MenuHomeFreeBSD

sndstat: nvlist schema and API definition changes
ClosedPublic

Authored by khng on Apr 15 2021, 9:10 AM.

Details

Summary
  • SNDSTAT_LABEL_* are renamed to SNDST_DSPS_*, and SNDSTAT_LABEL_DSPS becomes SNDST_DSPS.
  • Centralize channel number/rate/formats into a single nvlist The above nvlist is named "info_play" and "info_rec"
  • Expose only encoding format in pfmts/rfmts. Userland has no direct access to AFMT_ENCODING/CHANNEL/EXTCHANNEL macros, thus it serves no meaning to expose too much information through this pair of labels. However pminrate/rminrate, pmaxrate/rmaxrate, pfmts/rfmts are deprecated and will be removed in future.

This commit keeps ioctls ABI compatibility with __FreeBSD_version
1400006 for now. In future the compat ABI with 1400006 will be removed
once audio/virtual_oss is rebuilt.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khng requested review of this revision.Apr 15 2021, 9:10 AM

Found 3 typos, one of which was not yours. :-)

share/man/man4/sndstat.4
101

s/support/supports/

117

See above.

140–141

Oh look, a typo in the man page that was there before your change. Oops:

s/providede/provided/

You could fix this while you're here.

khng marked 3 inline comments as done.Apr 15 2021, 9:26 AM

Great, manpage part of the change is fine now.

This revision is now accepted and ready to land.Apr 15 2021, 9:35 AM

Looks good to me!

Approved by: philip (mentor)