- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 13 2020
May 12 2020
read(2) on a directory seems only useful for educational or debugging purposes. These purposes are better served by a different API.
Apr 28 2020
Apr 27 2020
Apr 25 2020
Apr 22 2020
Apr 20 2020
Feel free to commit this revision as is. I will handle -h in mkbuiltins.
Apr 18 2020
A follow-up is to delete -h from mkbuiltins and builtins.def.
Apr 17 2020
This solution looks inconsistent. Either fc and bind are always available (writing an error message if history is not compiled in), in which case mkbuiltins should not be omitting them, or they are not available if history is not compiled in, in which case the functions should not be defined at all if history is not compiled in.
Apr 14 2020
Disabling utx boot and utx shutdown does not prevent other parts of the system writing to the utx files. So by itself this disable creates utx files that are less useful. Disabling utx completely needs patching, at least the way things are now.
Apr 4 2020
Some people wrongly add whitespace via copy and paste, but let's be consistent with login, passwd, etc.
Mar 25 2020
Fine with me, assuming it still builds with recent GCC as well.
Mar 4 2020
Mar 2 2020
MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).
Feb 24 2020
In D23802#523379, @kib wrote:The buffer was written by the function, this is my point of the aliasing breakage.
Feb 19 2020
Feb 18 2020
Feb 16 2020
The bin/sh part looks OK.
Feb 12 2020
Feb 9 2020
Feb 4 2020
Jan 24 2020
What is the point of fputc_unlocked() given that putc_unlocked() already exists?
Jan 17 2020
Hmm, https://reviews.freebsd.org/D17083 proposes to change qsort_r() argument order to glibc's since that is likely to become POSIX standard and is slightly better than our order.
Jan 15 2020
In D12773#508215, @cem wrote:In fact, a very similar scenario is possible _today_ with sigprocmask:
Jan 14 2020
Jan 7 2020
The mq_notify() mechanism indeed needs to be considered here, but I think it already handles that:
Jan 1 2020
Dec 30 2019
Dec 16 2019
Dec 11 2019
Adding INTOFF/INTON around malloc/free prevents unsafety due to interrupting the allocator, but does not prevent memory leaks or double frees due to the administration getting out of sync with the allocator (for example, if the INTON in ckmalloc() notices an interrupt, the allocated memory will leak). It would make more sense if ckmalloc/ckrealloc/ckfree merely asserted that INTON is in effect. I experimented with that earlier but did not follow through.
Dec 7 2019
Dec 6 2019
Dec 4 2019
I think the part "to all processes with the same uid as the user" is rather vague now, and would probably be better written as "to all processes which the caller has permission to", given that permission checks are quite complicated nowadays.
Oct 18 2019
Historically, another reason was performance. For example, https://svnweb.freebsd.org/base?view=revision&revision=76801 which changed make(1) to be statically linked states performance as the reason.
Oct 9 2019
Looks good with one grammar issue. Don't forget to bump .Dd.
Oct 6 2019
Oct 5 2019
In D21903#478488, @kevans wrote:In D21903#478452, @kib wrote:I find it somewhat strange that you require global control to enable local setting. Less cryptic, I would expect to see per-process setting of 3 cases: 1. default/use sysctl, 2. enabled, 3. disabled.
Sep 29 2019
Sep 22 2019
Sep 18 2019
Sep 17 2019
Very useful, and good generalization of shm_open(SHM_ANON) and memfd_create().
Sep 16 2019
Add more volatile
Sep 15 2019
Add another testcase for access past end of non-empty object
Sep 14 2019
Sep 12 2019
Sep 10 2019
I like that this makes signal numbers and codes more architecture-independent and reduces the number of conversions of this information.
Sep 9 2019
Documentation for the _ variable was indeed missing.
Sep 4 2019
Remove no longer used variable MAX_TRIES
Sep 2 2019
Sep 1 2019
Aug 31 2019
Aug 29 2019
Aug 28 2019
This change looks reasonable, although the exact logic can be improved as noted. It may have been the original intent that $start_cmd use $_env by itself but that would involve replicating error-prone code.
Aug 27 2019
This seems to fit the model.
Aug 22 2019
Looks good to me.
Aug 6 2019
Aug 5 2019
Jul 31 2019
Perhaps it's better to convert ps to use getopt_long() so that we do not invent new single-letter options.
Jul 29 2019
Jul 21 2019
In D20969#455437, @darius-dons.net.au wrote:Definitely a generic way of achieving this would be nice, and it looks like you can set umask with a login class - to be honest if I had known about the "${name}_login_class" before now I would have used that rather than writing this patch.
Jul 18 2019
Perhaps it will be more generically useful to add a ${name}_umask variable to rc.subr instead.
Jul 5 2019
Jul 2 2019
May 21 2019
May 20 2019
In D19902#437991, @hrs wrote:In D19902#437962, @jilles wrote:Perhaps it is cleaner to pass the int age to be searched for by reference. However, the asymmetry in the compare function is intentional as this allows finding an object with more data given the key, while having only one storage array.
May 19 2019
I think it will be useful to have this. It fixes most of the drop in functionality when moving from System V shared memory to POSIX shared memory.
In D19902#437950, @hrs wrote:As already pointed out on the mailing list, this example has a lot of problems which are not only style bugs. Ones I think as critical except for the style issues are the following:
- The function to compare two elements should accept the same type, not using an "age" field value by using a pointer type. It is a function to compare, not look up a matched element in the definition of bsearch(3). Passing a raw value as (void *) type is not impossible, but it is not suitable for a "textbook" example.
May 7 2019
The new function sbuf_printf_drain was added recently enough that this should be safe (binaries using sbuf_printf_drain linked against the old libsbuf.so.6 will not run against the new libsbuf.so.6).
May 2 2019
In D20111#433337, @asomers wrote:In D20111#433326, @jilles wrote:In D20111#432908, @asomers wrote:Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.
May 1 2019
In D20111#432908, @asomers wrote:Not so fast! I just discovered a serious footgun: Linux's struct dirent has a
d_off field, but it's meaning is different than FreeBSD's. That's worth
mentioning.