Page MenuHomeFreeBSD

Add conv=fsync flag to dd
ClosedPublic

Authored by ryan_freqlabs.com on Thu, Aug 22, 7:07 PM.

Details

Reviewers
mmacy
jilles
imp
Group Reviewers
manpages
Summary

The fsync flag performs an fsync(2) on the output file before closing it. This will be useful for the ZFS test suite.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I am planning a followup to add the fdatasync flag, as well.

ryan_freqlabs.com edited the summary of this revision. (Show Details)Thu, Aug 22, 7:09 PM
jilles accepted this revision as: jilles.Thu, Aug 22, 8:36 PM
jilles added a subscriber: jilles.

Looks good to me.

bin/dd/dd.h
104

This uses up the last free bit, but that should be OK.

This revision is now accepted and ready to land.Thu, Aug 22, 8:36 PM
imp accepted this revision.Wed, Aug 28, 7:34 PM
imp added inline comments.
bin/dd/dd.c
513

do you also need to check close(2) calls?

bin/dd/dd.c
513