Page MenuHomeFreeBSD
Differential D21373

Add conv=fdatasync flag to dd
ClosedPublic
Actions

Authored by freqlabs on Aug 22 2019, 8:44 PM.

Details

Reviewers
jilles
mmacy
imp
Group Reviewers
manpages
Commits
rS352920: Add conv=fdatasync flag to dd
Summary

The fdatasync flag performs an fdatasync(2) on the output file before closing it. This will be useful for the ZFS test suite.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

freqlabs created this revision.Aug 22 2019, 8:44 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 22 2019, 8:44 PM
Herald added a subscriber: imp. · View Herald Transcript
freqlabs added a parent revision: D21370: Add conv=fsync flag to dd.Aug 22 2019, 8:47 PM
freqlabs added a comment.Aug 22 2019, 11:39 PM

I will check the result of close(2) in a follow-up patch as suggested in PR229616

bcr accepted this revision as: manpages.Aug 23 2019, 10:52 AM
bcr added a subscriber: bcr.

OK from manpages, but bump the .Dd when committing for this content change.
Thank you!

freqlabs added a child revision: D21376: dd: Check result of close(2) for errors.Aug 23 2019, 1:45 PM
freqlabs added reviewers: mmacy, imp.Sep 3 2019, 5:45 PM
mmacy accepted this revision.Sep 30 2019, 9:43 PM
This revision is now accepted and ready to land.Sep 30 2019, 9:43 PM
Closed by commit rS352920: Add conv=fdatasync flag to dd (authored by mmacy). · Explain WhySep 30 2019, 9:48 PM
This revision was automatically updated to reflect the committed changes.
mmacy added a commit: rS352920: Add conv=fdatasync flag to dd.

Revision Contents
Changeset List

PathSize
head/
bin/
dd/
5 lines
65 lines
4 lines
7 lines
2 lines

Diff 62773

View Options

head/bin/dd/args.c

Loading...
View Options

head/bin/dd/dd.h

Loading...
View Options

head/bin/dd/dd.1

Loading...
View Options

head/bin/dd/dd.c

Loading...
View Options

head/bin/dd/extern.h

Loading...