Page MenuHomeFreeBSD

Add conv=fsync flag to dd
ClosedPublic

Authored by freqlabs on Aug 22 2019, 7:07 PM.
Tags
None
Referenced Files
F82028523: D21370.diff
Wed, Apr 24, 6:10 PM
Unknown Object (File)
Mon, Apr 22, 4:30 AM
Unknown Object (File)
Dec 22 2023, 10:57 PM
Unknown Object (File)
Dec 14 2023, 6:51 PM
Unknown Object (File)
Dec 2 2023, 1:33 AM
Unknown Object (File)
Nov 19 2023, 2:13 PM
Unknown Object (File)
Nov 5 2023, 5:15 PM
Unknown Object (File)
Oct 4 2023, 4:13 PM
Subscribers

Details

Reviewers
mmacy
jilles
imp
Group Reviewers
manpages
Summary

The fsync flag performs an fsync(2) on the output file before closing it. This will be useful for the ZFS test suite.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I am planning a followup to add the fdatasync flag, as well.

jilles added a subscriber: jilles.

Looks good to me.

bin/dd/dd.h
104

This uses up the last free bit, but that should be OK.

This revision is now accepted and ready to land.Aug 22 2019, 8:36 PM
imp added inline comments.
bin/dd/dd.c
513

do you also need to check close(2) calls?