Page MenuHomeFreeBSD

procstat/tests: Fix flakiness by waiting for program to start
ClosedPublic

Authored by jilles on Sep 4 2019, 2:00 PM.

Details

Summary

Some of the procstat tests start a program "while1" and examine the process
using procstat, but did not wait properly for it to start (kill -0 will
succeed immediately after the child process has been created).

Instead, have "while1" write something when it starts, and use a fifo to
wait for that.

PR: 233587, 233588

Test Plan

sh -c 'while kyua test; do :; done'
and let it continue for a while

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jilles created this revision.Sep 4 2019, 2:00 PM
jilles updated this revision to Diff 61646.Sep 4 2019, 2:06 PM

Remove no longer used variable MAX_TRIES

ngie accepted this revision.Sep 4 2019, 2:20 PM

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

This revision is now accepted and ready to land.Sep 4 2019, 2:20 PM
This revision was automatically updated to reflect the committed changes.