Page MenuHomeFreeBSD

procstat/tests: Fix flakiness by waiting for program to start
ClosedPublic

Authored by jilles on Sep 4 2019, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 6:17 PM
Unknown Object (File)
Thu, Dec 26, 7:46 AM
Unknown Object (File)
Dec 4 2024, 9:29 AM
Unknown Object (File)
Nov 18 2024, 6:47 AM
Unknown Object (File)
Nov 15 2024, 4:27 AM
Unknown Object (File)
Nov 2 2024, 8:59 AM
Unknown Object (File)
Nov 1 2024, 11:04 PM
Unknown Object (File)
Oct 4 2024, 6:23 PM
Subscribers

Details

Summary

Some of the procstat tests start a program "while1" and examine the process
using procstat, but did not wait properly for it to start (kill -0 will
succeed immediately after the child process has been created).

Instead, have "while1" write something when it starts, and use a fifo to
wait for that.

PR: 233587, 233588

Test Plan

sh -c 'while kyua test; do :; done'
and let it continue for a while

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove no longer used variable MAX_TRIES

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

This revision is now accepted and ready to land.Sep 4 2019, 2:20 PM