Page MenuHomeFreeBSD

procstat/tests: Fix flakiness by waiting for program to start
ClosedPublic

Authored by jilles on Sep 4 2019, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 6:21 AM
Unknown Object (File)
Mon, Sep 29, 11:05 AM
Unknown Object (File)
Sat, Sep 20, 6:59 PM
Unknown Object (File)
Sat, Sep 20, 1:52 AM
Unknown Object (File)
Aug 30 2025, 10:02 PM
Unknown Object (File)
Aug 5 2025, 4:07 AM
Unknown Object (File)
Jul 29 2025, 1:15 AM
Unknown Object (File)
Jul 28 2025, 1:09 PM
Subscribers

Details

Summary

Some of the procstat tests start a program "while1" and examine the process
using procstat, but did not wait properly for it to start (kill -0 will
succeed immediately after the child process has been created).

Instead, have "while1" write something when it starts, and use a fifo to
wait for that.

PR: 233587, 233588

Test Plan

sh -c 'while kyua test; do :; done'
and let it continue for a while

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove no longer used variable MAX_TRIES

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

This revision is now accepted and ready to land.Sep 4 2019, 2:20 PM