Page MenuHomeFreeBSD
Differential D24181

sh(1): bump WARNS
ClosedPublic
Actions

Authored by trasz on Mar 25 2020, 3:37 PM.
Tags
None
Referenced Files
F135270480: D24181.id70093.diff
Sat, Nov 8, 4:11 AM
Unknown Object (File)
Sat, Nov 1, 6:07 AM
Unknown Object (File)
Fri, Oct 24, 11:41 PM
Unknown Object (File)
Sat, Oct 18, 8:50 AM
Unknown Object (File)
Sat, Oct 18, 8:50 AM
Unknown Object (File)
Sat, Oct 18, 8:49 AM
Unknown Object (File)
Fri, Oct 17, 9:25 PM
Unknown Object (File)
Fri, Oct 17, 8:54 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
jilles
Commits
rS359511: Bump WARNS for sh(1).
Summary

Bump WARNS for sh(1). Tinderbox suggests sh(1) builds fine without
those two lines.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Mar 25 2020, 3:37 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 25 2020, 3:37 PM
Harbormaster completed remote builds in B30094: Diff 69857.Mar 25 2020, 3:37 PM
jilles accepted this revision.Mar 25 2020, 5:57 PM

Fine with me, assuming it still builds with recent GCC as well.

I think this is possible thanks to the removal of GCC 4.2.1, which had warnings related to setjmp and vfork that were unreasonable to fix.

This revision is now accepted and ready to land.Mar 25 2020, 5:57 PM
trasz added a comment.Mar 26 2020, 6:44 PM

The warnings are still there with GCC 9, but they don't break the build due to -Wno-error=clobbered.

Closed by commit rS359511: Bump WARNS for sh(1). (authored by trasz). · Explain WhyApr 1 2020, 3:13 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS359511: Bump WARNS for sh(1)..

Revision Contents
Changeset List

PathSize
head/
bin/
sh/
2 lines

Diff 70093

View Options

head/bin/sh/Makefile

Loading...