Details
Details
- Reviewers
jilles - Commits
- rS360139: Fix build with NO_HISTORY set
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This solution looks inconsistent. Either fc and bind are always available (writing an error message if history is not compiled in), in which case mkbuiltins should not be omitting them, or they are not available if history is not compiled in, in which case the functions should not be defined at all if history is not compiled in.
The latter approach will produce the smallest binaries, so I think it is best.
Comment Actions
I have no opinions on how this should work. I was just trying to follow what was there. The presence of -h is definitely inconsistent now. If you want to pick this up and pick the right route that's fine with me.