This solution looks inconsistent. Either fc and bind are always available (writing an error message if history is not compiled in), in which case mkbuiltins should not be omitting them, or they are not available if history is not compiled in, in which case the functions should not be defined at all if history is not compiled in.

The latter approach will produce the smallest binaries, so I think it is best.

This revision now requires changes to proceed.Apr 17 2020, 11:46 AM

builtins.h does define these prototypes

Harbormaster completed remote builds in B30566: Diff 70705.Apr 17 2020, 5:54 PM

OK.

A follow-up is to delete -h from mkbuiltins and builtins.def.

This revision is now accepted and ready to land.Apr 18 2020, 9:20 PM

I have no opinions on how this should work. I was just trying to follow what was there. The presence of -h is definitely inconsistent now. If you want to pick this up and pick the right route that's fine with me.

Feel free to commit this revision as is. I will handle -h in mkbuiltins.

Closed by commit rS360139: Fix build with NO_HISTORY set (authored by bdrewery). · Explain WhyApr 21 2020, 12:38 AM

This revision was automatically updated to reflect the committed changes.

bdrewery added a commit: rS360139: Fix build with NO_HISTORY set.

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2020, 12:38 AM