Ship it.

In D42719#978596, @michaelo wrote:

In D42719#978591, @otis wrote:

Does this (set -e) have any consequences on existing flow?

I'd say yes. I will fail immediately (fail-fast) when a command exits with non-zero. That's the point. Better be fail than be sorry. My initial problem was a bad NIS setup which I cannot fix at the moment, but the currect create script did not fail, thus left me with a halfbroken installation. I prefer no installation instead of a broken one. I think this should also be on 14 and 13 since it will improve realibility and will affect only a few users.

Does this (set -e) have any consequences on existing flow?

In D42720#974504, @michaelo wrote:

In D42720#974495, @otis wrote:

I don't object either. Nevertheless it seems to me that this should be performed in post-install-LOCALBASE_CACERTS-on within the STAGEDIR. What's your thought?

While I agree with you, I have chosen the approach from TZUPDATE for consistency reasons.

I don't object either. Nevertheless it seems to me that this should be performed in post-install-LOCALBASE_CACERTS-on within the STAGEDIR. What's your thought?

Catch missed nit.

Address comments.

Rebase

Catch missed variable rename in rc.d script.

Then also I guess also manpages should be installed unconditionally (and adjusting pkg-plist).

Then LGTM. Ship it.

This port is just too complex and complicated for me to do the review thoroughly.

Closed in commit ec69541aaabafb36d0dcebf3427611357eced022

A very friendly ping? :-)

Backport commit b6c67a6eb191c1832815a76c990cac08bc9ee0f2 from upstream.

In D42130#964712, @otis wrote:

In D42130#964699, @glewis wrote:

In D42130#963017, @glewis wrote:

I think this could be a lot simpler

FWIW, I think https://github.com/battleblow/jdk17u/commit/b6c67a6eb191c1832815a76c990cac08bc9ee0f2 is all we need to do here. I haven't tested this against the UniFi controller though.

I will give it a go. This seems like a very simplified version of what they are doing for Linux (and that I took as a foundation for BSD).

In D42130#964699, @glewis wrote:

In D42130#963017, @glewis wrote:

I think this could be a lot simpler

FWIW, I think https://github.com/battleblow/jdk17u/commit/b6c67a6eb191c1832815a76c990cac08bc9ee0f2 is all we need to do here. I haven't tested this against the UniFi controller though.

Reduce diff

Remove stray WRKSRC assignment.

In D39761#956203, @emaste wrote:

It seems we have quite a delay after "Preparing to download files..." (independent of this change, I believe), but the "Fetching..." output looks good

Fetching metadata signature for 14.0-BETA2 from update2.freebsd.org... done.
Fetching metadata index... done.
Fetching 1 metadata patches... done.
Applying metadata patches... done.
Fetching 1 metadata files... done.
Inspecting system... done.
Fetching files from 13.2-RELEASE for merging... done.
Preparing to download files... 
load: 1.05  cmd: sha256 7348 [runnable] 0.00r 0.00u 0.00s 0% 2204k
mi_switch+0xc2 intr_event_handle+0x167 intr_execute_handlers+0x4b Xapic_isr1+0xdc 
load: 1.09  cmd: gzip 92095 [runnable] 0.00r 0.00u 0.00s 10% 3344k
mi_switch+0xc2 intr_event_handle+0x167 intr_execute_handlers+0x4b Xapic_isr1+0xdc vm_fault+0x92b vm_fault_trap+0x6d trap_pfault+0x1f3 trap+0x440 calltrap+0x8 
done.
Fetching 10732 patches... 310/10732

OBE

Print final message properly.

Address the comment.

Tested, working, LGTM.

I see inconsistent use of quotes around variable dereference (sometimes ${BASEDIR, sometimes "${BASEDIR}"). Other than that LGTM.

Address some comments.

Abandoning this revision, it's the same as D39037