PR: 274598
Approved by: jrm (mentor)
Release Notes: https://maven.apache.org/docs/3.9.5/release-notes.html
Details
Details
- Reviewers
jrm otis - Commits
- R11:14de8dddfe92: devel/maven39: Update to 3.9.5
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good. Don't forget about Differential Revision: https://reviews.freebsd.org/D42300. Phab isn't the best at showing spacing, but was the commit message derived from the local git hooks? It looks like there might not be two tabs after PR: and one after Approved by:.
Comment Actions
I actually did upfront, but arc told me:
Does this look OK? [y/N] y Usage Exception: There is no revision D42300. git-arc: could not create Phabricator diff
I have aleady amended the commit.
Regarding tabs: you are right, I have one too much:
1 devel/maven39: Update to 3.9.5$ 2 $ 3 PR:^I^I274598$ 4 Approved by:^Ijrm (mentor)$ 5 Differential Revision:^Ihttps://reviews.freebsd.org/D42300$ 6 Release Notes:^Ihttps://maven.apache.org/docs/3.9.5/release-notes.html$ 7 $
Though with a tabstop of 4 in vim it is not aligned anymore.