Page MenuHomeFreeBSD

devel/maven39: Update to 3.9.5
ClosedPublic

Authored by michaelo on Oct 19 2023, 4:27 PM.
Tags
None
Referenced Files
F166731081: D42300.id129109.diff
Sat, Aug 15, 9:57 PM
Unknown Object (File)
Fri, Aug 14, 9:24 PM
Unknown Object (File)
Thu, Aug 13, 7:20 PM
Unknown Object (File)
Wed, Aug 12, 8:38 PM
Unknown Object (File)
Wed, Aug 12, 3:41 PM
Unknown Object (File)
Wed, Aug 12, 9:32 AM
Unknown Object (File)
Tue, Aug 11, 11:27 PM
Unknown Object (File)
Tue, Aug 11, 9:15 PM
Subscribers
None

Details

Summary

PR: 274598
Approved by: jrm (mentor)
Release Notes: https://maven.apache.org/docs/3.9.5/release-notes.html

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.

Looks good. Don't forget about Differential Revision: https://reviews.freebsd.org/D42300. Phab isn't the best at showing spacing, but was the commit message derived from the local git hooks? It looks like there might not be two tabs after PR: and one after Approved by:.

This revision is now accepted and ready to land.Oct 19 2023, 4:38 PM
In D42300#965125, @jrm wrote:

Looks good. Don't forget about Differential Revision: https://reviews.freebsd.org/D42300. Phab isn't the best at showing spacing, but was the commit message derived from the local git hooks? It looks like there might not be two tabs after PR: and one after Approved by:.

I actually did upfront, but arc told me:

Does this look OK? [y/N] y
Usage Exception: There is no revision D42300.
git-arc: could not create Phabricator diff

I have aleady amended the commit.

Regarding tabs: you are right, I have one too much:

1 devel/maven39: Update to 3.9.5$
2 $
3 PR:^I^I274598$
4 Approved by:^Ijrm (mentor)$
5 Differential Revision:^Ihttps://reviews.freebsd.org/D42300$
6 Release Notes:^Ihttps://maven.apache.org/docs/3.9.5/release-notes.html$
7 $

Though with a tabstop of 4 in vim it is not aligned anymore.

This revision was automatically updated to reflect the committed changes.