Page MenuHomeFreeBSD

freebsd-update: do not restart jailed sshd
ClosedPublic

Authored by emaste on Sep 16 2023, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 1:20 AM
Unknown Object (File)
Tue, Apr 23, 1:20 AM
Unknown Object (File)
Tue, Apr 23, 1:20 AM
Unknown Object (File)
Tue, Apr 23, 1:20 AM
Unknown Object (File)
Tue, Apr 23, 12:46 AM
Unknown Object (File)
Mar 16 2024, 3:19 AM
Unknown Object (File)
Mar 16 2024, 3:19 AM
Unknown Object (File)
Mar 16 2024, 3:19 AM
Subscribers

Details

Summary

In 6cd1bc531609 for PR 263489 I changed freebsd-update to restart sshd after upgrade, to avoid an upgrade-related incompatibility that made it impossible to login.

This is intended to avoid losing access to remote hosts, and ought not apply to upgrading a jail.

PR: 263489, 272282

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

Test $BASEDIR instead of $JAIL; we should not do the sshd restart dance for -b either.

I see inconsistent use of quotes around variable dereference (sometimes ${BASEDIR, sometimes "${BASEDIR}"). Other than that LGTM.

I'll test it on some jails I have left to update.

Tested, working, LGTM.

This revision is now accepted and ready to land.Sep 17 2023, 10:26 AM

I was going to complain from the description that I could only have access to the jail and be updating from within, but I reckon BASEDIR would be / in that case

I was going to complain from the description that I could only have access to the jail and be updating from within

Will update the commit message to make this clear