java/openjdk17: Implement "Current thread CPU time measurement"

[otis]

Summary

Similarly to Linux, implement "Current thread CPU time measurement"
functionality.

Tested with recent UniFi controller (not yet in ports, that requires
OpenJDK 17+) which would not run properly without this functionaoity,
giving the following error:

ERROR [dispatcher] - Servlet.service() for servlet [dispatcher] in
context with path [] threw exception [Request processing failed; nested
exception is
com.google.common.util.concurrent.UncheckedExecutionException:
java.lang.UnsupportedOperationException: Current thread CPU time
measurement is not supported.]
with root cause
java.lang.UnsupportedOperationException: Current thread CPU time
measurement is not supported.

[glewis]

I think this could be a lot simpler

java/openjdk17/files/patch-src_hotspot_os_bsd_os__bsd.cpp

6–9 ↗

(On Diff #128448)

I don't think we need most of the code in this change. The Linux code is complicated because it has to deal with some Linux distributions or versions supporting this and others not. I don't believe this is true on FreeBSD. I think all supported FreeBSD platforms do support it and all this code has to do is just set _getcpuclockid to pthread_getcpuclockid here. It seems like OpenBSD and NetBSD also support it for recent versions, so I don't think we need any special casing for them either. Just an assignment.

[otis]

Reduce diff

[glewis]

In D42130#963017, @glewis wrote:

I think this could be a lot simpler

FWIW, I think https://github.com/battleblow/jdk17u/commit/b6c67a6eb191c1832815a76c990cac08bc9ee0f2 is all we need to do here. I haven't tested this against the UniFi controller though.

[otis]

In D42130#964699, @glewis wrote:

In D42130#963017, @glewis wrote:

I think this could be a lot simpler

FWIW, I think https://github.com/battleblow/jdk17u/commit/b6c67a6eb191c1832815a76c990cac08bc9ee0f2 is all we need to do here. I haven't tested this against the UniFi controller though.

I will give it a go. This seems like a very simplified version of what they are doing for Linux (and that I took as a foundation for BSD).

[otis]

In D42130#964712, @otis wrote:

In D42130#964699, @glewis wrote:

In D42130#963017, @glewis wrote:

I think this could be a lot simpler

FWIW, I think https://github.com/battleblow/jdk17u/commit/b6c67a6eb191c1832815a76c990cac08bc9ee0f2 is all we need to do here. I haven't tested this against the UniFi controller though.

I will give it a go. This seems like a very simplified version of what they are doing for Linux (and that I took as a foundation for BSD).

Ok, I've tested this and it works OK (as it is basically a simplified version of my proposed change).

I'll update the review.

[otis]

Backport commit b6c67a6eb191c1832815a76c990cac08bc9ee0f2 from upstream.

[otis]

A very friendly ping? :-)

[glewis]

In D42130#965494, @otis wrote:

A very friendly ping? :-)

Thank you for doing this Juraj! I think it is now obsolete as it got incorporated into the 17.0.9 update that got forced by the security announcement from Oracle late last week. The good news is that I was able to pull it into the new openjdk21 port as well