Page MenuHomeFreeBSD

cleanup: set generic version for devel/subversion
ClosedPublic

Authored by michaelo on Oct 24 2023, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 8:34 AM
Unknown Object (File)
Fri, Oct 3, 10:40 PM
Unknown Object (File)
Fri, Oct 3, 3:54 PM
Unknown Object (File)
Wed, Oct 1, 12:20 PM
Unknown Object (File)
Wed, Sep 24, 12:41 PM
Unknown Object (File)
Wed, Sep 24, 3:57 AM
Unknown Object (File)
Mon, Sep 22, 5:52 PM
Unknown Object (File)
Mon, Sep 22, 2:27 PM
Subscribers
None

Details

Summary

PR: 253566
Approved by: jrm (mentor), otis (mentor), maintainer timeout

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.
devel/p5-SVN-Hooks/Makefile
20

I wonder why are > and >= intermixed here.

devel/p5-SVN-Hooks/Makefile
20

Looking at the Porter's Handbook it should be >0. I will fix for hunks I have changed. Good catch.

Issue addressed.

Guys, please have a look at this again. It is straight forward.

devel/p5-SVN-Hooks/Makefile
20

If no particular version is required, just omit the version range specifier. That is, just use svn:devel/subversion as you did below for portshaker.

devel/p5-SVN-Look/Makefile
18

Same comment as above.

devel/statsvn/Makefile
14

Same comment as above.

Drop portshaker because it is an invalid change.

While you are right, there is a difference. Portshaker depends on the executable svn, but the other ports depend on the package. I don't know whether they do use the executable or not. Having said that, I think this is still correct. The Portshaker hunk is wrong, antoine@ pointed me to this.

This revision is now accepted and ready to land.Oct 27 2023, 1:37 PM