Page MenuHomeFreeBSD

php.mk: Create php extension ini files as sample
ClosedPublic

Authored by otis on Aug 29 2023, 11:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 7, 7:46 AM
Unknown Object (File)
Dec 23 2023, 1:15 AM
Unknown Object (File)
Nov 18 2023, 10:17 AM
Unknown Object (File)
Nov 18 2023, 10:17 AM
Unknown Object (File)
Nov 18 2023, 5:02 AM
Unknown Object (File)
Nov 15 2023, 2:16 PM
Unknown Object (File)
Nov 10 2023, 6:33 PM
Unknown Object (File)
Oct 17 2023, 6:20 PM
Subscribers

Details

Summary

Create php extension ini files with .sample extension
to prevent subsequent upgrades from clobbering the, possibly,
user-modified .ini files.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis requested review of this revision.Aug 29 2023, 11:05 AM

In theory those files were not designed to be modified by the user. What's the use case that requires it and that cannot be done via another php configuration file?

In D41630#949078, @ale wrote:

In theory those files were not designed to be modified by the user. What's the use case that requires it and that cannot be done via another php configuration file?

The actual use case, for me, is that I have an unified set of extensions of which one (opcache) is causing problems in one particular installation. That's why I want to be able to comment it out without subsequent update to activate it again.

Moreover, it's a handy place to put extension's configuration into.

I haven't tested the patch but it looks fine. What do you think @bofh ?

In D41630#949988, @ale wrote:

I haven't tested the patch but it looks fine. What do you think @bofh ?

As you approve it I will run a smaller exp-run on this and revert back after I finish my exp-run on newer version of php81 and php82. :)

I can't see any potential drawback in this change, so if it works as expected I approve it. Waiting for your exp-run feeback.

This revision is now accepted and ready to land.Sep 4 2023, 5:51 AM