In D39620#1008905, @sean_rogue-research.com wrote:stable/13 has this patch
releng/13.2 doesn't have this patch (yet).I'm not very familiar with FreeBSD's branching system... I see FreeBSD 13.3-RELEASE was released today, is this bug fix included?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 5 2024
Mar 5 2024
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
stable/13 has this patch
releng/13.2 doesn't have this patch (yet).
Mar 4 2024
Mar 4 2024
Feb 20 2024
Feb 20 2024
freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.
Thanks to all of you for moving this along so swiftly! I've already started working on the next iteration. Will post that soon.
Thanks again!
Feb 17 2024
Feb 17 2024
Feb 16 2024
Feb 16 2024
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Combining Ed's and Rod's feedback on processors: removing controversial paragraph on Intel architecture
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
I asked some doc committers on IRC to have a look.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
- Updated paragraph on CPU architecture to reference Nehalem instead.
- Added --usage reference for vmstart.sh
- Fixed disconnect key sequence for cu
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
freebsd_ny-central.org added inline comments to D43899: Improvements for Handbook: section virtualization.
Its getting much better, probably with pushing a commit soon.
Feb 15 2024
Feb 15 2024
freebsd_ny-central.org added a comment to D43899: Improvements for Handbook: section virtualization.
Included the relevant feedback points into this latest update. Thanks for the great inputs. Any further inputs/feedback welcome!
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
And finally condensed the processor feature constraints into a simpler and shorter statement.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Included additional updates after Rod's feedback. Thanks for the inputs!
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Sorry, just realized I missed the -U99999; included this now.
freebsd_ny-central.org updated the diff for D43899: Improvements for Handbook: section virtualization.
Updates after initial feedback - also fixed version of ISO files in the command line listings.
Oh, one other comment - when you regenerate the new patch please use -U999999 to get full context - Phabricator will then allow the reader to expand the blocks in between what's been changed.
Just some nits.
freebsd_ny-central.org planned changes to D43899: Improvements for Handbook: section virtualization.
Thanks for the great feedback. I'll update the patch accordingly.
Feb 14 2024
Feb 14 2024
Thanks. These are nice updates. I added a few mostly nit-picky comments and added a few other reviewers.
freebsd_ny-central.org requested review of D43899: Improvements for Handbook: section virtualization.
Feb 6 2024
Feb 6 2024
Move vm_snapshot_buf_cmp prototype under #ifndef _KERNEL.
Looks good to me, aside from the comment.
gusev.vitaliy_gmail.com retitled D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT from vmm: Fix compilation with BHYVE_SNAPSHOT to vmm: Fix compiling error with BHYVE_SNAPSHOT.
removed vm_snapshot_buf_cmp() in the kernel code
gusev.vitaliy_gmail.com added inline comments to D43754: vmm: Fix compiling error with BHYVE_SNAPSHOT.
Removed vm_snapshot_buf_cmp() function in the kernel code.
Feb 5 2024
Feb 5 2024
Dec 29 2023
Dec 29 2023
markj added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
In D43218#985321, @rew wrote:In D43218#985292, @markj wrote:This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.
I went ahead and took care of these, hopefully you don't mind.
rew added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
In D43218#985292, @markj wrote:This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.
This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.
Dec 28 2023
Dec 28 2023
gusev.vitaliy_gmail.com updated the summary of D43226: vmm: [snapshot] MTRR should be saved/restored.
gusev.vitaliy_gmail.com added a comment to D43218: bhyve: [snapshot] increase SNAPSHOT_BUFFER_SIZE according with fbuf size.
In D43218#985023, @rew wrote:as a side thought, wondering if FB_SIZE and SNAPSHOT_BUFFER_SIZE should be computed on the fly at some point in the future.
This looks good - thanks for the fix.
Dec 12 2023
Dec 12 2023
Address @jhb 's comments.
Dec 7 2023
Dec 7 2023
Note, there is still a hole here I think which is that the RFLAGS pushed as part of an exception frame when an exception or interrupt occurs can "leak" the shadow TF into the guest. That is, if you have enabled RFLAGS.TF to request a step and the guest takes an interrupt, the saved copy of RFLAGS on the stack will have TF set. Masking hardware interrupts during stepping prevents a good bit of this, but if the code hits an exception it will still leak the shadow TF. That isn't fatal, per se, but might be something to think about fixing at some point. I think the fix is you have to hook all exceptions and rewrite the saved RFLAGS on the stack similar to what happens now for PUSHF/POPF. You'd also need to deal with IRET as well so you can rewrite the saved RFLAGS on the stack before letting IRET continue.
This generally looks fine to me modulo some nits. I think we should probably remove checking for the VM_CAP_MASK_HWINTR capability though.
Dec 5 2023
Dec 5 2023
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
It could be, but I would expect that Linux 6.x kernel just changed behaviour a little and therefore race caused that issue is rarely seen.
gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
In D39620#978525, @sean_rogue-research.com wrote:Assuming the bug I see is indeed this bug, I reproduce in all 3 of my linux VMs, running Ubuntu 20.04 LTS and 22.04 LTS, which are all linux kernel 5.x. Looks like there is no LTS Ubuntu with kernel 6.x until upcoming 24.04. But 23.10 uses kernel 6.5, which I could try. Is kernel 6.x expected to fix something?
Dec 4 2023
Dec 4 2023
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
stable/13 has this patch
gusev.vitaliy_gmail.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
In D39620#978503, @sean_rogue-research.com wrote:...
I'm not very familiar with phabricator, so I'm unsure: is this fixed in FreeBSD 13.2 or only 14.0?
sean_rogue-research.com added a comment to D39620: vmm: Fix HLT loop while vcpu has requested virtual interrupts.
Hi all,
Nov 30 2023
Nov 30 2023
Address @jhb 's comments.
Nov 29 2023
Nov 29 2023
Nov 7 2023
Nov 7 2023
In D34718#969176, @freebsd_ny-central.org wrote:That's all. Kernel crashes with panic: general protection fault. Who wants to fix that ?)
I've read through the various open reviews and your suggestions for a new file format on the mailing list. Would a more robust file format fix that? I.e. adding a checksum or signing the file with a cryptographic hash?
Nov 5 2023
Nov 5 2023
In D34718#926530, @gusev.vitaliy_gmail.com wrote:In D34718#925884, @gusev.vitaliy_gmail.com wrote:I suppose that fixing existing issues and make the code stable is more important for now.
And if somebody feels that snapshot code is stable enough for adding new features, I would say it is not!
You can simply crash host with the following steps:
- Suspend VM
- Run "dd if=/dev/zero bs=1K count=1 conv=notrunc of=${snapshot}.kern"
- Resume VM
That's all. Kernel crashes with panic: general protection fault. Who wants to fix that ?)
Oct 30 2023
Oct 30 2023
bnovkov added inline comments to D42298: bhyve: refactor gdbstub to enable single-stepping on AMD CPUs.
bnovkov added inline comments to D42298: bhyve: refactor gdbstub to enable single-stepping on AMD CPUs.
Address @corvink 's comments.
Address @corvink 's comments.
Maybe add some more information to the commit message. Something like "This commit adds a new capability to enable software breakpoints. When enabled, vmexits are passed to userspace where they should be handled. ..."
corvink added inline comments to D42298: bhyve: refactor gdbstub to enable single-stepping on AMD CPUs.
Oct 19 2023
Oct 19 2023
bnovkov retitled D42295: vmm: enable software breakpoints for AMD CPUs from vmm: enable software breakpoints for AMD SVM to vmm: enable software breakpoints for AMD CPUs.
Oct 17 2023
Oct 17 2023
markj accepted D42260: bhyve: [snapshot] Remove init_snapshot() and initialize static vars directly.
Please mail me git format-patch output and I'll apply it.
Sep 28 2023
Sep 28 2023
Sep 27 2023
Sep 27 2023
Sep 21 2023
Sep 21 2023
Sep 15 2023
Sep 15 2023