In D39196#892545, @theraven wrote:

This looks fine to me. Assuming I'm reading the code correctly, this change is only for targets where int64_t is long, so there should be no change in any C++ / ObjC name mangling as a result of this. It's a bit curious that we explicitly define it as a fixed-width type for 32-bit targets but long for 64-bit prior to this change, did I do that?

In D39193#892427, @brooks wrote:

In D39193#892418, @emaste wrote:

I notice x86 uses __LONG_MIN and __LONG_MAX

I'm tempted to switch that to INT64_* and remove the machine/_limits.h pollution added in 703fbbe36fdb6

In D39193#892415, @jrtc27 wrote:

riscv copied this mistake. amd64 had its fixed in https://github.com/freebsd/freebsd-src/commit/38d1ac34ff82bd2aeb308b52a65b686060e52873. powerpc64(le) is correct.

In D39193#892418, @emaste wrote:

I notice x86 uses __LONG_MIN and __LONG_MAX

Here's the check in gnulib

I think I ended up as reviewer due to license issues when I was on core. It seems stalled, but I'm not quite ready to commandeer and abandon it.

Obsoleted by rG9e914c7af1f3d176acf2712e5a86a9a6a7b779c6

It looks like limits are now based on CPU cores per VM type https://cirrus-ci.org/faq/#are-there-any-limits (though were GCP instances fit in to that I'm not entirely sure.). I do see the job is stuck behind the main one so maybe we should just put theses scripts in the main job (perhaps limiting makeman to one architecture).

• Recase as housekeeping rather than generated file
• Check that L*DIRS exist in include/Makefile

Reword slightly

Committed in rGaf0cc0b22362153357d7b6783f64c4a11b1b03fe

Committed as rG105a4f7b3cb65bc159d6a3fe0b2570c2f6475db5

In D38991#887515, @emaste wrote:

Do we expect that the src.conf.5/generated sysent files will be included in the same commit, or that one should stage two commits locally for one push? (We should probably document that somewhere, afaik src.conf.5 and sysent are primarily lore at this point)

Actually committing depends on adding the missing descriptions in D38961 as well as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270017.

Fix typo

Remove /usr/include/netnatm in make delete-old

Catch up to WITHOUT_ATM being the default

I've got a src.conf.5 regen in my tree, but it doesn't seem worth a review.

Just remembered this requires some changes. One would need to add a tools/build/options/WITH_ATM and rebuild src.conf.5. Maybe I should just delete it with the ATM removal.

See D38879 and D38880. It's probably worth committing this first.