Add makefs to the list of bootstrap tools
AbandonedPublic
Actions

Authored by brooks on Dec 15 2020, 1:16 PM.

Details

Reviewers

emaste
bdrewery
imp
arichardson

Summary

Having this as part of the bootstrap tools is useful to build disk images
to boot in QEMU (especially when building on a Linux/macOS host where
mkimg is not available). We have been bootstrapping makefs+mkimg in
CheriBSD for a long time (using LOCAL_XTOOL_DIRS) but I believe this
is also useful upstream.

Depends on D27602

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40344
Build 37233: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Dec 15 2020, 1:16 PM

arichardson created this revision.

Harbormaster completed remote builds in B35415: Diff 80719.Dec 15 2020, 1:16 PM

ping?

emaste added inline comments.Jan 29 2021, 5:32 PM

Makefile.inc1
2501	can we not just leave the dependency in place, if we don't actually need `${_bt}-lib/netbsd` it won't matter?

arichardson mentioned this in D28679: vnode: move write cluster support data to inodes..Feb 21 2021, 12:57 PM

arichardson mentioned this in D28835: Fix makefs bootstrap after d485c77f203fb0f4cdc08dea5ff81631b51d8809.Feb 21 2021, 3:13 PM

Drop unnecessary check

Harbormaster completed remote builds in B37278: Diff 84485.Feb 22 2021, 5:55 PM

Looks OK to me, tiny concern is whether _libnetbsd= lib/libmd lib/libnetbsd could become out of sync (exists in two places)

In D27619#646233, @emaste wrote:

Looks OK to me, tiny concern is whether _libnetbsd= lib/libmd lib/libnetbsd could become out of sync (exists in two places)

Yeah I don't like that either but I'm not sure if there's an easy way to avoid it.

Add comment to keep the two assignments synchronized

Harbormaster completed remote builds in B40344: Diff 91864.Jul 6 2021, 9:56 AM