Page MenuHomeFreeBSD
Differential D38882

Remove WITH(OUT)_ATM option
ClosedPublic
Actions

Authored by brooks on Mar 3 2023, 12:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 2:45 AM
Unknown Object (File)
Wed, Mar 26, 9:20 AM
Unknown Object (File)
Wed, Mar 26, 8:02 AM
Unknown Object (File)
Feb 22 2025, 2:07 PM
Unknown Object (File)
Feb 20 2025, 8:01 PM
Unknown Object (File)
Feb 11 2025, 10:27 PM
Unknown Object (File)
Jan 30 2025, 9:20 AM
Unknown Object (File)
Jan 29 2025, 7:44 AM
View All 91 Files
Subscribers
bdrewery
imp

Details

Reviewers
emaste
manu
Commits
rGaad600e52e8b: Remove WITH(OUT)_ATM option
Summary

With the removal of NgATM it no longer controls anything.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
share/
man/
man5/
mk/
2 lines
tools/
build/
options/
tools/
nanobsd/
dhcpd/
1 line
embedded/
1 line

Diff 118583

View Options

share/man/man5/src.conf.5

  • This file was added.
/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (C) 2022 Wanpeng Qian <wanpengqian@gmail.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/ioccom.h>
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <sys/endian.h>
#include "nvmecontrol.h"
struct samsung_log_extended_smart
{
uint8_t kv[256];/* Key-Value pair */
uint32_t lwaf; /* Lifetime Write Amplification */
uint32_t thwaf; /* Trailing Hour Write Amplification Factor */
uint64_t luw[2]; /* Lifetime User Writes */
uint64_t lnw[2]; /* Lifetime NAND Writes */
uint64_t lur[2]; /* Lifetime User Reads */
uint32_t lrbc; /* Lifetime Retired Block Count */
uint16_t ct; /* Current Temperature */
uint16_t ch; /* Capacitor Health */
uint32_t luurb; /* Lifetime Unused Reserved Block */
uint64_t rrc; /* Read Reclaim Count */
uint64_t lueccc; /* Lifetime Uncorrectable ECC count */
uint32_t lurb; /* Lifetime Used Reserved Block */
uint64_t poh[2]; /* Power on Hours */
uint64_t npoc[2];/* Normal Power Off Count */
uint64_t spoc[2];/* Sudden Power Off Count */
uint32_t pi; /* Performance Indicator */
} __packed;
static void
print_samsung_extended_smart(const struct nvme_controller_data *cdata __unused, void *buf, uint32_t size __unused)
{
struct samsung_log_extended_smart *temp = buf;
char cbuf[UINT128_DIG + 1];
uint8_t *walker = buf;
uint8_t *end = walker + 150;
const char *name;
uint64_t raw;
uint8_t normalized;
static struct kv_name kv[] =
{
{ 0xab, "Lifetime Program Fail Count" },
{ 0xac, "Lifetime Erase Fail Count" },
{ 0xad, "Lifetime Wear Leveling Count" },
{ 0xb8, "Lifetime End to End Error Count" },
{ 0xc7, "Lifetime CRC Error Count" },
{ 0xe2, "Media Wear %" },
{ 0xe3, "Host Read %" },
{ 0xe4, "Workload Timer" },
{ 0xea, "Lifetime Thermal Throttle Status" },
{ 0xf4, "Lifetime Phy Pages Written Count" },
{ 0xf5, "Lifetime Data Units Written" },
};
printf("Extended SMART Information\n");
printf("=========================\n");
/*
* walker[0] = Key
* walker[1,2] = reserved
* walker[3] = Normalized Value
* walker[4] = reserved
* walker[5..10] = Little Endian Raw value
* (or other represenations)
* walker[11] = reserved
*/
while (walker < end) {
name = kv_lookup(kv, nitems(kv), *walker);
normalized = walker[3];
raw = le48dec(walker + 5);
switch (*walker){
case 0:
break;
case 0xad:
printf("%2X %-41s: %3d min: %u max: %u ave: %u\n",
le16dec(walker), name, normalized,
le16dec(walker + 5), le16dec(walker + 7), le16dec(walker + 9));
break;
case 0xe2:
printf("%2X %-41s: %3d %.3f%%\n",
le16dec(walker), name, normalized,
raw / 1024.0);
break;
case 0xea:
printf("%2X %-41s: %3d %d%% %d times\n",
le16dec(walker), name, normalized,
walker[5], le32dec(walker+6));
break;
default:
printf("%2X %-41s: %3d %ju\n",
le16dec(walker), name, normalized,
(uintmax_t)raw);
impUnsubmitted
Not Done
Inline Actions

All the printfs from here on down need to be converted from le to host.

imp: All the printfs from here on down need to be converted from le to host.
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

For 128bit values, do I need to convert two 64bits first? I am not sure.

wanpengqian_gmail.com: For 128bit values, do I need to convert two 64bits first? I am not sure.
impUnsubmitted
Not Done
Inline Actions

Yes. However, we should have a le128dec function that we can use here. We don't and now that I'm looking at a lot of the rest of the code, I see that printing the other log pages isn't quite endian correct (Which is why we don't have a le128dec). For now, leave the 128 bit stuff as is and I'll do a pass to fix them all (if someone else does not do it first).

imp: Yes. However, we should have a le128dec function that we can use here. We don't and now that…
break;
}
walker += 12;
}
printf(" Lifetime Write Amplification Factor : %u\n", le32dec(&temp->lwaf));
printf(" Trailing Hour Write Amplification Factor : %u\n", le32dec(&temp->thwaf));
printf(" Lifetime User Writes : %s\n",
uint128_to_str(to128(temp->luw), cbuf, sizeof(cbuf)));
printf(" Lifetime NAND Writes : %s\n",
uint128_to_str(to128(temp->lnw), cbuf, sizeof(cbuf)));
printf(" Lifetime User Reads : %s\n",
impUnsubmitted
Not Done
Inline Actions

that's a quite odd name for erase block reserve

imp: that's a quite odd name for erase block reserve
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I use Reserved Erase Block Count to match others' style

wanpengqian_gmail.com: I use Reserved Erase Block Count to match others' style
impUnsubmitted
Not Done
Inline Actions

That sounds fine.

imp: That sounds fine.
uint128_to_str(to128(temp->lur), cbuf, sizeof(cbuf)));
printf(" Lifetime Retired Block Count : %u\n", le32dec(&temp->lrbc));
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I change UECC to Uncorrectable ECC here. seems reasonable.

wanpengqian_gmail.com: I change UECC to Uncorrectable ECC here. seems reasonable.
impUnsubmitted
Not Done
Inline Actions

That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.

imp: That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.
printf(" Current Temperature : ");
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of sectors reallocated....

imp: That's an odd name for number of sectors reallocated....
print_temp(le16dec(&temp->ct));
printf(" Capacitor Health : %u\n", le16dec(&temp->ch));
printf(" Reserved Erase Block Count : %u\n", le32dec(&temp->luurb));
impUnsubmitted
Not Done
Inline Actions

NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out would be slightly less bad, but still obscure.

imp: NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

is Normal Power Off Count seems odd?

wanpengqian_gmail.com: is Normal Power Off Count seems odd?
impUnsubmitted
Not Done
Inline Actions

That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.

imp: That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.
printf(" Read Reclaim Count : %lu\n", le64dec(&temp->rrc));
printf(" Lifetime Uncorrectable ECC Count : %lu\n", le64dec(&temp->lueccc));
printf(" Reallocated Block Count : %u\n", le32dec(&temp->lurb));
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden power off here.

imp: That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

use Sudden Power Off Count to match the datasheet's description.

wanpengqian_gmail.com: use Sudden Power Off Count to match the datasheet's description.
impUnsubmitted
Not Done
Inline Actions

Great!

imp: Great!
printf(" Power on Hours : %s\n",
uint128_to_str(to128(temp->poh), cbuf, sizeof(cbuf)));
printf(" Normal Power Off Count : %s\n",
uint128_to_str(to128(temp->npoc), cbuf, sizeof(cbuf)));
printf(" Sudden Power Off Count : %s\n",
uint128_to_str(to128(temp->spoc), cbuf, sizeof(cbuf)));
printf(" Performance Indicator : %u\n", le32dec(&temp->pi));
}
#define SAMSUNG_LOG_EXTEND_SMART 0xca
NVME_LOGPAGE(samsung_extended_smart,
SAMSUNG_LOG_EXTEND_SMART, "samsung", "Extended SMART Information",
print_samsung_extended_smart, DEFAULT_SIZE);
View Options

share/mk/src.opts.mk

  • This file was added.
/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (C) 2022 Wanpeng Qian <wanpengqian@gmail.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/ioccom.h>
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <sys/endian.h>
#include "nvmecontrol.h"
struct samsung_log_extended_smart
{
uint8_t kv[256];/* Key-Value pair */
uint32_t lwaf; /* Lifetime Write Amplification */
uint32_t thwaf; /* Trailing Hour Write Amplification Factor */
uint64_t luw[2]; /* Lifetime User Writes */
uint64_t lnw[2]; /* Lifetime NAND Writes */
uint64_t lur[2]; /* Lifetime User Reads */
uint32_t lrbc; /* Lifetime Retired Block Count */
uint16_t ct; /* Current Temperature */
uint16_t ch; /* Capacitor Health */
uint32_t luurb; /* Lifetime Unused Reserved Block */
uint64_t rrc; /* Read Reclaim Count */
uint64_t lueccc; /* Lifetime Uncorrectable ECC count */
uint32_t lurb; /* Lifetime Used Reserved Block */
uint64_t poh[2]; /* Power on Hours */
uint64_t npoc[2];/* Normal Power Off Count */
uint64_t spoc[2];/* Sudden Power Off Count */
uint32_t pi; /* Performance Indicator */
} __packed;
static void
print_samsung_extended_smart(const struct nvme_controller_data *cdata __unused, void *buf, uint32_t size __unused)
{
struct samsung_log_extended_smart *temp = buf;
char cbuf[UINT128_DIG + 1];
uint8_t *walker = buf;
uint8_t *end = walker + 150;
const char *name;
uint64_t raw;
uint8_t normalized;
static struct kv_name kv[] =
{
{ 0xab, "Lifetime Program Fail Count" },
{ 0xac, "Lifetime Erase Fail Count" },
{ 0xad, "Lifetime Wear Leveling Count" },
{ 0xb8, "Lifetime End to End Error Count" },
{ 0xc7, "Lifetime CRC Error Count" },
{ 0xe2, "Media Wear %" },
{ 0xe3, "Host Read %" },
{ 0xe4, "Workload Timer" },
{ 0xea, "Lifetime Thermal Throttle Status" },
{ 0xf4, "Lifetime Phy Pages Written Count" },
{ 0xf5, "Lifetime Data Units Written" },
};
printf("Extended SMART Information\n");
printf("=========================\n");
/*
* walker[0] = Key
* walker[1,2] = reserved
* walker[3] = Normalized Value
* walker[4] = reserved
* walker[5..10] = Little Endian Raw value
* (or other represenations)
* walker[11] = reserved
*/
while (walker < end) {
name = kv_lookup(kv, nitems(kv), *walker);
normalized = walker[3];
raw = le48dec(walker + 5);
switch (*walker){
case 0:
break;
case 0xad:
printf("%2X %-41s: %3d min: %u max: %u ave: %u\n",
le16dec(walker), name, normalized,
le16dec(walker + 5), le16dec(walker + 7), le16dec(walker + 9));
break;
case 0xe2:
printf("%2X %-41s: %3d %.3f%%\n",
le16dec(walker), name, normalized,
raw / 1024.0);
break;
case 0xea:
printf("%2X %-41s: %3d %d%% %d times\n",
le16dec(walker), name, normalized,
walker[5], le32dec(walker+6));
break;
default:
printf("%2X %-41s: %3d %ju\n",
le16dec(walker), name, normalized,
(uintmax_t)raw);
impUnsubmitted
Not Done
Inline Actions

All the printfs from here on down need to be converted from le to host.

imp: All the printfs from here on down need to be converted from le to host.
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

For 128bit values, do I need to convert two 64bits first? I am not sure.

wanpengqian_gmail.com: For 128bit values, do I need to convert two 64bits first? I am not sure.
impUnsubmitted
Not Done
Inline Actions

Yes. However, we should have a le128dec function that we can use here. We don't and now that I'm looking at a lot of the rest of the code, I see that printing the other log pages isn't quite endian correct (Which is why we don't have a le128dec). For now, leave the 128 bit stuff as is and I'll do a pass to fix them all (if someone else does not do it first).

imp: Yes. However, we should have a le128dec function that we can use here. We don't and now that…
break;
}
walker += 12;
}
printf(" Lifetime Write Amplification Factor : %u\n", le32dec(&temp->lwaf));
printf(" Trailing Hour Write Amplification Factor : %u\n", le32dec(&temp->thwaf));
printf(" Lifetime User Writes : %s\n",
uint128_to_str(to128(temp->luw), cbuf, sizeof(cbuf)));
printf(" Lifetime NAND Writes : %s\n",
uint128_to_str(to128(temp->lnw), cbuf, sizeof(cbuf)));
printf(" Lifetime User Reads : %s\n",
impUnsubmitted
Not Done
Inline Actions

that's a quite odd name for erase block reserve

imp: that's a quite odd name for erase block reserve
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I use Reserved Erase Block Count to match others' style

wanpengqian_gmail.com: I use Reserved Erase Block Count to match others' style
impUnsubmitted
Not Done
Inline Actions

That sounds fine.

imp: That sounds fine.
uint128_to_str(to128(temp->lur), cbuf, sizeof(cbuf)));
printf(" Lifetime Retired Block Count : %u\n", le32dec(&temp->lrbc));
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I change UECC to Uncorrectable ECC here. seems reasonable.

wanpengqian_gmail.com: I change UECC to Uncorrectable ECC here. seems reasonable.
impUnsubmitted
Not Done
Inline Actions

That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.

imp: That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.
printf(" Current Temperature : ");
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of sectors reallocated....

imp: That's an odd name for number of sectors reallocated....
print_temp(le16dec(&temp->ct));
printf(" Capacitor Health : %u\n", le16dec(&temp->ch));
printf(" Reserved Erase Block Count : %u\n", le32dec(&temp->luurb));
impUnsubmitted
Not Done
Inline Actions

NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out would be slightly less bad, but still obscure.

imp: NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

is Normal Power Off Count seems odd?

wanpengqian_gmail.com: is Normal Power Off Count seems odd?
impUnsubmitted
Not Done
Inline Actions

That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.

imp: That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.
printf(" Read Reclaim Count : %lu\n", le64dec(&temp->rrc));
printf(" Lifetime Uncorrectable ECC Count : %lu\n", le64dec(&temp->lueccc));
printf(" Reallocated Block Count : %u\n", le32dec(&temp->lurb));
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden power off here.

imp: That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

use Sudden Power Off Count to match the datasheet's description.

wanpengqian_gmail.com: use Sudden Power Off Count to match the datasheet's description.
impUnsubmitted
Not Done
Inline Actions

Great!

imp: Great!
printf(" Power on Hours : %s\n",
uint128_to_str(to128(temp->poh), cbuf, sizeof(cbuf)));
printf(" Normal Power Off Count : %s\n",
uint128_to_str(to128(temp->npoc), cbuf, sizeof(cbuf)));
printf(" Sudden Power Off Count : %s\n",
uint128_to_str(to128(temp->spoc), cbuf, sizeof(cbuf)));
printf(" Performance Indicator : %u\n", le32dec(&temp->pi));
}
#define SAMSUNG_LOG_EXTEND_SMART 0xca
NVME_LOGPAGE(samsung_extended_smart,
SAMSUNG_LOG_EXTEND_SMART, "samsung", "Extended SMART Information",
print_samsung_extended_smart, DEFAULT_SIZE);
View Options

tools/build/options/WITHOUT_ATM

  • This file was added.
/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (C) 2022 Wanpeng Qian <wanpengqian@gmail.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/ioccom.h>
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <sys/endian.h>
#include "nvmecontrol.h"
struct samsung_log_extended_smart
{
uint8_t kv[256];/* Key-Value pair */
uint32_t lwaf; /* Lifetime Write Amplification */
uint32_t thwaf; /* Trailing Hour Write Amplification Factor */
uint64_t luw[2]; /* Lifetime User Writes */
uint64_t lnw[2]; /* Lifetime NAND Writes */
uint64_t lur[2]; /* Lifetime User Reads */
uint32_t lrbc; /* Lifetime Retired Block Count */
uint16_t ct; /* Current Temperature */
uint16_t ch; /* Capacitor Health */
uint32_t luurb; /* Lifetime Unused Reserved Block */
uint64_t rrc; /* Read Reclaim Count */
uint64_t lueccc; /* Lifetime Uncorrectable ECC count */
uint32_t lurb; /* Lifetime Used Reserved Block */
uint64_t poh[2]; /* Power on Hours */
uint64_t npoc[2];/* Normal Power Off Count */
uint64_t spoc[2];/* Sudden Power Off Count */
uint32_t pi; /* Performance Indicator */
} __packed;
static void
print_samsung_extended_smart(const struct nvme_controller_data *cdata __unused, void *buf, uint32_t size __unused)
{
struct samsung_log_extended_smart *temp = buf;
char cbuf[UINT128_DIG + 1];
uint8_t *walker = buf;
uint8_t *end = walker + 150;
const char *name;
uint64_t raw;
uint8_t normalized;
static struct kv_name kv[] =
{
{ 0xab, "Lifetime Program Fail Count" },
{ 0xac, "Lifetime Erase Fail Count" },
{ 0xad, "Lifetime Wear Leveling Count" },
{ 0xb8, "Lifetime End to End Error Count" },
{ 0xc7, "Lifetime CRC Error Count" },
{ 0xe2, "Media Wear %" },
{ 0xe3, "Host Read %" },
{ 0xe4, "Workload Timer" },
{ 0xea, "Lifetime Thermal Throttle Status" },
{ 0xf4, "Lifetime Phy Pages Written Count" },
{ 0xf5, "Lifetime Data Units Written" },
};
printf("Extended SMART Information\n");
printf("=========================\n");
/*
* walker[0] = Key
* walker[1,2] = reserved
* walker[3] = Normalized Value
* walker[4] = reserved
* walker[5..10] = Little Endian Raw value
* (or other represenations)
* walker[11] = reserved
*/
while (walker < end) {
name = kv_lookup(kv, nitems(kv), *walker);
normalized = walker[3];
raw = le48dec(walker + 5);
switch (*walker){
case 0:
break;
case 0xad:
printf("%2X %-41s: %3d min: %u max: %u ave: %u\n",
le16dec(walker), name, normalized,
le16dec(walker + 5), le16dec(walker + 7), le16dec(walker + 9));
break;
case 0xe2:
printf("%2X %-41s: %3d %.3f%%\n",
le16dec(walker), name, normalized,
raw / 1024.0);
break;
case 0xea:
printf("%2X %-41s: %3d %d%% %d times\n",
le16dec(walker), name, normalized,
walker[5], le32dec(walker+6));
break;
default:
printf("%2X %-41s: %3d %ju\n",
le16dec(walker), name, normalized,
(uintmax_t)raw);
impUnsubmitted
Not Done
Inline Actions

All the printfs from here on down need to be converted from le to host.

imp: All the printfs from here on down need to be converted from le to host.
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

For 128bit values, do I need to convert two 64bits first? I am not sure.

wanpengqian_gmail.com: For 128bit values, do I need to convert two 64bits first? I am not sure.
impUnsubmitted
Not Done
Inline Actions

Yes. However, we should have a le128dec function that we can use here. We don't and now that I'm looking at a lot of the rest of the code, I see that printing the other log pages isn't quite endian correct (Which is why we don't have a le128dec). For now, leave the 128 bit stuff as is and I'll do a pass to fix them all (if someone else does not do it first).

imp: Yes. However, we should have a le128dec function that we can use here. We don't and now that…
break;
}
walker += 12;
}
printf(" Lifetime Write Amplification Factor : %u\n", le32dec(&temp->lwaf));
printf(" Trailing Hour Write Amplification Factor : %u\n", le32dec(&temp->thwaf));
printf(" Lifetime User Writes : %s\n",
uint128_to_str(to128(temp->luw), cbuf, sizeof(cbuf)));
printf(" Lifetime NAND Writes : %s\n",
uint128_to_str(to128(temp->lnw), cbuf, sizeof(cbuf)));
printf(" Lifetime User Reads : %s\n",
impUnsubmitted
Not Done
Inline Actions

that's a quite odd name for erase block reserve

imp: that's a quite odd name for erase block reserve
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I use Reserved Erase Block Count to match others' style

wanpengqian_gmail.com: I use Reserved Erase Block Count to match others' style
impUnsubmitted
Not Done
Inline Actions

That sounds fine.

imp: That sounds fine.
uint128_to_str(to128(temp->lur), cbuf, sizeof(cbuf)));
printf(" Lifetime Retired Block Count : %u\n", le32dec(&temp->lrbc));
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I change UECC to Uncorrectable ECC here. seems reasonable.

wanpengqian_gmail.com: I change UECC to Uncorrectable ECC here. seems reasonable.
impUnsubmitted
Not Done
Inline Actions

That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.

imp: That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.
printf(" Current Temperature : ");
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of sectors reallocated....

imp: That's an odd name for number of sectors reallocated....
print_temp(le16dec(&temp->ct));
printf(" Capacitor Health : %u\n", le16dec(&temp->ch));
printf(" Reserved Erase Block Count : %u\n", le32dec(&temp->luurb));
impUnsubmitted
Not Done
Inline Actions

NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out would be slightly less bad, but still obscure.

imp: NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

is Normal Power Off Count seems odd?

wanpengqian_gmail.com: is Normal Power Off Count seems odd?
impUnsubmitted
Not Done
Inline Actions

That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.

imp: That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.
printf(" Read Reclaim Count : %lu\n", le64dec(&temp->rrc));
printf(" Lifetime Uncorrectable ECC Count : %lu\n", le64dec(&temp->lueccc));
printf(" Reallocated Block Count : %u\n", le32dec(&temp->lurb));
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden power off here.

imp: That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

use Sudden Power Off Count to match the datasheet's description.

wanpengqian_gmail.com: use Sudden Power Off Count to match the datasheet's description.
impUnsubmitted
Not Done
Inline Actions

Great!

imp: Great!
printf(" Power on Hours : %s\n",
uint128_to_str(to128(temp->poh), cbuf, sizeof(cbuf)));
printf(" Normal Power Off Count : %s\n",
uint128_to_str(to128(temp->npoc), cbuf, sizeof(cbuf)));
printf(" Sudden Power Off Count : %s\n",
uint128_to_str(to128(temp->spoc), cbuf, sizeof(cbuf)));
printf(" Performance Indicator : %u\n", le32dec(&temp->pi));
}
#define SAMSUNG_LOG_EXTEND_SMART 0xca
NVME_LOGPAGE(samsung_extended_smart,
SAMSUNG_LOG_EXTEND_SMART, "samsung", "Extended SMART Information",
print_samsung_extended_smart, DEFAULT_SIZE);
View Options

tools/build/options/WITH_ATM

  • This file was added.
/*-
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
*
* Copyright (C) 2022 Wanpeng Qian <wanpengqian@gmail.org>
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/ioccom.h>
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <sys/endian.h>
#include "nvmecontrol.h"
struct samsung_log_extended_smart
{
uint8_t kv[256];/* Key-Value pair */
uint32_t lwaf; /* Lifetime Write Amplification */
uint32_t thwaf; /* Trailing Hour Write Amplification Factor */
uint64_t luw[2]; /* Lifetime User Writes */
uint64_t lnw[2]; /* Lifetime NAND Writes */
uint64_t lur[2]; /* Lifetime User Reads */
uint32_t lrbc; /* Lifetime Retired Block Count */
uint16_t ct; /* Current Temperature */
uint16_t ch; /* Capacitor Health */
uint32_t luurb; /* Lifetime Unused Reserved Block */
uint64_t rrc; /* Read Reclaim Count */
uint64_t lueccc; /* Lifetime Uncorrectable ECC count */
uint32_t lurb; /* Lifetime Used Reserved Block */
uint64_t poh[2]; /* Power on Hours */
uint64_t npoc[2];/* Normal Power Off Count */
uint64_t spoc[2];/* Sudden Power Off Count */
uint32_t pi; /* Performance Indicator */
} __packed;
static void
print_samsung_extended_smart(const struct nvme_controller_data *cdata __unused, void *buf, uint32_t size __unused)
{
struct samsung_log_extended_smart *temp = buf;
char cbuf[UINT128_DIG + 1];
uint8_t *walker = buf;
uint8_t *end = walker + 150;
const char *name;
uint64_t raw;
uint8_t normalized;
static struct kv_name kv[] =
{
{ 0xab, "Lifetime Program Fail Count" },
{ 0xac, "Lifetime Erase Fail Count" },
{ 0xad, "Lifetime Wear Leveling Count" },
{ 0xb8, "Lifetime End to End Error Count" },
{ 0xc7, "Lifetime CRC Error Count" },
{ 0xe2, "Media Wear %" },
{ 0xe3, "Host Read %" },
{ 0xe4, "Workload Timer" },
{ 0xea, "Lifetime Thermal Throttle Status" },
{ 0xf4, "Lifetime Phy Pages Written Count" },
{ 0xf5, "Lifetime Data Units Written" },
};
printf("Extended SMART Information\n");
printf("=========================\n");
/*
* walker[0] = Key
* walker[1,2] = reserved
* walker[3] = Normalized Value
* walker[4] = reserved
* walker[5..10] = Little Endian Raw value
* (or other represenations)
* walker[11] = reserved
*/
while (walker < end) {
name = kv_lookup(kv, nitems(kv), *walker);
normalized = walker[3];
raw = le48dec(walker + 5);
switch (*walker){
case 0:
break;
case 0xad:
printf("%2X %-41s: %3d min: %u max: %u ave: %u\n",
le16dec(walker), name, normalized,
le16dec(walker + 5), le16dec(walker + 7), le16dec(walker + 9));
break;
case 0xe2:
printf("%2X %-41s: %3d %.3f%%\n",
le16dec(walker), name, normalized,
raw / 1024.0);
break;
case 0xea:
printf("%2X %-41s: %3d %d%% %d times\n",
le16dec(walker), name, normalized,
walker[5], le32dec(walker+6));
break;
default:
printf("%2X %-41s: %3d %ju\n",
le16dec(walker), name, normalized,
(uintmax_t)raw);
impUnsubmitted
Not Done
Inline Actions

All the printfs from here on down need to be converted from le to host.

imp: All the printfs from here on down need to be converted from le to host.
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

For 128bit values, do I need to convert two 64bits first? I am not sure.

wanpengqian_gmail.com: For 128bit values, do I need to convert two 64bits first? I am not sure.
impUnsubmitted
Not Done
Inline Actions

Yes. However, we should have a le128dec function that we can use here. We don't and now that I'm looking at a lot of the rest of the code, I see that printing the other log pages isn't quite endian correct (Which is why we don't have a le128dec). For now, leave the 128 bit stuff as is and I'll do a pass to fix them all (if someone else does not do it first).

imp: Yes. However, we should have a le128dec function that we can use here. We don't and now that…
break;
}
walker += 12;
}
printf(" Lifetime Write Amplification Factor : %u\n", le32dec(&temp->lwaf));
printf(" Trailing Hour Write Amplification Factor : %u\n", le32dec(&temp->thwaf));
printf(" Lifetime User Writes : %s\n",
uint128_to_str(to128(temp->luw), cbuf, sizeof(cbuf)));
printf(" Lifetime NAND Writes : %s\n",
uint128_to_str(to128(temp->lnw), cbuf, sizeof(cbuf)));
printf(" Lifetime User Reads : %s\n",
impUnsubmitted
Not Done
Inline Actions

that's a quite odd name for erase block reserve

imp: that's a quite odd name for erase block reserve
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I use Reserved Erase Block Count to match others' style

wanpengqian_gmail.com: I use Reserved Erase Block Count to match others' style
impUnsubmitted
Not Done
Inline Actions

That sounds fine.

imp: That sounds fine.
uint128_to_str(to128(temp->lur), cbuf, sizeof(cbuf)));
printf(" Lifetime Retired Block Count : %u\n", le32dec(&temp->lrbc));
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

I change UECC to Uncorrectable ECC here. seems reasonable.

wanpengqian_gmail.com: I change UECC to Uncorrectable ECC here. seems reasonable.
impUnsubmitted
Not Done
Inline Actions

That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.

imp: That's fine. UECC or Uncorrectable ECC are both reasonable, and the latter is a little better.
printf(" Current Temperature : ");
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of sectors reallocated....

imp: That's an odd name for number of sectors reallocated....
print_temp(le16dec(&temp->ct));
printf(" Capacitor Health : %u\n", le16dec(&temp->ch));
printf(" Reserved Erase Block Count : %u\n", le32dec(&temp->luurb));
impUnsubmitted
Not Done
Inline Actions

NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out would be slightly less bad, but still obscure.

imp: NPO? That's an odd name for the number of clean shutdowns. Number of Power Off spelled out…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

is Normal Power Off Count seems odd?

wanpengqian_gmail.com: is Normal Power Off Count seems odd?
impUnsubmitted
Not Done
Inline Actions

That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.

imp: That's fine. I think it's what NPO is short for and it will save others having to puzzle it out.
printf(" Read Reclaim Count : %lu\n", le64dec(&temp->rrc));
printf(" Lifetime Uncorrectable ECC Count : %lu\n", le64dec(&temp->lueccc));
printf(" Reallocated Block Count : %u\n", le32dec(&temp->lurb));
impUnsubmitted
Not Done
Inline Actions

That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden power off here.

imp: That's an odd name for number of unclean shutdowns, though I see the data sheet uses sudden…
wanpengqian_gmail.comAuthorUnsubmitted
Done
Inline Actions

use Sudden Power Off Count to match the datasheet's description.

wanpengqian_gmail.com: use Sudden Power Off Count to match the datasheet's description.
impUnsubmitted
Not Done
Inline Actions

Great!

imp: Great!
printf(" Power on Hours : %s\n",
uint128_to_str(to128(temp->poh), cbuf, sizeof(cbuf)));
printf(" Normal Power Off Count : %s\n",
uint128_to_str(to128(temp->npoc), cbuf, sizeof(cbuf)));
printf(" Sudden Power Off Count : %s\n",
uint128_to_str(to128(temp->spoc), cbuf, sizeof(cbuf)));
printf(" Performance Indicator : %u\n", le32dec(&temp->pi));
}
#define SAMSUNG_LOG_EXTEND_SMART 0xca
NVME_LOGPAGE(samsung_extended_smart,
SAMSUNG_LOG_EXTEND_SMART, "samsung", "Extended SMART Information",
print_samsung_extended_smart, DEFAULT_SIZE);
View Options

tools/tools/nanobsd/dhcpd/common

Loading...
View Options

tools/tools/nanobsd/embedded/common

Loading...