• Only remove freebsd32 bits

In D32994#745067, @kib wrote:

In D32994#745062, @brooks wrote:

In D32994#745048, @kib wrote:

Well, this makes kern_fspacectl() useless and not providing the expectation for kern_* that arguments are already in the KVA, isn't it?

I'd prefer to keep kern_fspacectl() as I need it in CheriBSD. I will make it static so it will have zero cost in practice.

I mean keep kern_, but do copyin/out in sys_.

In D32994#745048, @kib wrote:

Well, this makes kern_fspacectl() useless and not providing the expectation for kern_* that arguments are already in the KVA, isn't it?

@khng points out that rqsr won't ever be NULL in kern_fspacectl. I was misled by the if (rqsr == NULL) that should have been a KASSERT (or nonexistent). I'll update the review shortly.

Seems fine. Does it make sense to add a gone_in to the mount code in the kernel?

If you're using a bin directory I'd use bin suggest bin as it's likely to be hit earlier.

Thinking about @markj's idea, a BADHDRS variable to filter out headers from a generated list wouldn't be hard to maintain.

The CloudABI case could have easily been support by D31349 or an extension on top of it to specify always-applied flags.

llvm bits look good

• Adopt reviewer suggestions
• Render "or" consistently

• Separate PROT_NONE from other arguments

As requested in D30442, this improves the wording of the description of the prot argument.

Per the discussion in D30442 this removes the incorrect description of mprotect granularity. Documentation of large pages is left for later.

At long last I've created a pair of reviews implementing the original change to mprotect in this review: D31776 and D31777

• Handle fspacectl
• Add a note that there is no functional change

-rebase

• Documentation moved to D31349

• Move syscalls.master documentation update here

This seems reasonable. I'll commit with a PORTREVISION bump. I'll try to look into doing a merge to quarterly (I'd been thinking of just doing a full sync up to 12.0.1).

Note: this was tested by running make sysent and verifying that nothing changed.