This may have been leftover from some early soft-partitioning work where the host was running on CPU 0 (and low CPUs) with bhyve and a single-guest running on the remainder with halt-exits disabled.

I'd say until snapshots are enabled by default, there are no guarantees.

Looks fine.

In practice this hasn't been an issue since a) guests use ECAM for config access, or b) mask off the lower bits (e.g. Linux routines in arch/x86/pci/direct.c).

In D31578#712408, @c.koehne_beckhoff.com wrote:

Add option -l fwcfg,<name> to select either QEMU or bhyve fwcfg.

What are the features that you're looking to get from Qemu fwcfg ?

• An E820 table. It could help D26209.

...

• ACPI/SMBIOS tables. Don't know if it's benefitial, yet.

Double-accounting for memory is a never-ending issue in bhyve :(

There's zero reason to change for this alone, and it requires a flag day for both bhyve and UEFI firmware which has thus far been avoided.

As next step bhyve could implement more fwcfg items from QEMU to use QEMU's features without developing an own firmware implementation.

Bhyve's fwctl only passes the number of vcpus to the guest. That could be done easily by QEMU's fwcfg.

No POLA concerns: this is fine. Thanks bz.

• Invert sense of SEVL printing.

The register printing may be a bit verbose: feedback welcome.

AArch32 Instruction Set Attributes 5 = <CRC32,SHA2,SHA1,AES+VMULL>
AArch32 Media and VFP Features 0 = <FPRound,FPSqrt,FPDivide,DP VFPv3+v4,SP VFPv3+v4,AdvSIMD>
AArch32 Media and VFP Features 1 = <SIMDFMAC,FPHP DP Conv,SIMDHP SP Conv,SIMDSP,SIMDInt,SIMDLS,FPDNaN,FPFtZ>

• Remove HWCAP32_THUMBEE as this is unused in ARMv8
• Update COMPAT HWCAP comments to reflect ARMv8 usage.
• Print aarch32 regs, and compare across all CPUs.
• Remove _EL1 from register defines.
• Fix typo in ID_ISAR5_VCMA_IMPL constant.
• FPshVec -> FPShVec in register defines.
• Review feedback on register names

Thanks: I'll pull in changes for this with the fix for checking caps across CPUs.

• Remove HWCAP32_THUMBEE as this is unused in ARMv8
• Update COMPAT HWCAP comments to reflect ARMv8 usage.

• Merge e1000 commit 4b38eed76d for promisc filter handling.

• Use correct SPDX identifier and move to after copyrights.

I don't see any glaring problems with it that should block it from going upstream. Are you going to announce this addition on the mailing lists?

• "ethernet" -> "Ethernet"

• Fix up copyrights based on review feedback.
• Consistent capitalization of I225

Even absent my new draft, there's already a few files in the tree with this construct, so these should be fine going in prior to it being finalized.

Verified this works with a mouse on Win10.

bcran that's just informational: it still works fine.

In D30462#684409, @kib wrote:

I believe SMAP on AMD is very recent feature, AFAIR it is not present on Zen2.

From dmesg on a FreeBSD-14 guest on a Ryzen 4700U.

The uuid is being correctly validated in smbiostbl.c:smbios_type1_initializer() so there's no need to do it again. An fprintf to stderr there indicatiing it is invalid is fine, and the assert on a return from smbios_build() can be changed into an exit(1).

the least effort would be to not touch this review and commit the already reviewed patch to main.

Looks fine, and preserves #GP on writes.

Want to abandon this one and re-submit ?

This is worth having.

Looks good.

Rod, why is your opinion so important ?

Fixes the issue for me.

Looks fine: please fix the #define on submit.

The older bhyve edk2 f/w can be built with up to gcc7, if gcc48 needs to be killed off

(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222233#c7)

Maybe ping ctuffli/imp for nvme.h, since that may involve removing other unecessary __packed's

Yes for the bhyve parts.

Good catch rew :)

Thanks for doing this; a long overdue change.

D28962 now committed with 95331c228a39