bhyve: Add support for EVFILT_VNODE mevents.
ClosedPublic
Actions

Authored by jhb on May 27 2021, 1:24 PM.

Details

Reviewers

grehan
markj

Group Reviewers

bhyve

Commits

rGd7e2c1479ccf: bhyve: Add support for EVFILT_VNODE mevents.
rG67d60dcce62c: bhyve: Add support for EVFILT_VNODE mevents.

Summary

This allows registering an event to watch for changes to a file's
attributes. This is a bit imperfect as it would be nice to have a way
to determine if an fd can use EVFILT_VNODE successfully. mevent's
current structure does not permit that and a failure to register a
single kevent impacts several other kevents.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 27 2021, 1:24 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMay 27 2021, 1:24 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.May 27 2021, 1:24 PM

jhb added a parent revision: D30502: bhyve: Register new kevents synchronously..

Harbormaster completed remote builds in B39507: Diff 90000.May 27 2021, 1:24 PM

jhb added a child revision: D30504: bhyve: Add support for handling disk resize events to block_if..May 27 2021, 1:24 PM

markj accepted this revision as: markj.Jun 2 2021, 4:01 PM

This revision is now accepted and ready to land.Jun 2 2021, 4:01 PM

grehan accepted this revision.Jun 3 2021, 12:54 PM

Closed by commit rG67d60dcce62c: bhyve: Add support for EVFILT_VNODE mevents. (authored by jhb). · Explain WhyJun 12 2021, 1:01 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG67d60dcce62c: bhyve: Add support for EVFILT_VNODE mevents..

arichardson added a subscriber: arichardson.Jun 22 2021, 1:04 PM

arichardson added inline comments.

usr.sbin/bhyve/mevent.c

189

GCC appears to be complaining about this:

/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_READ' not handled in switch [-Werror=switch]
  switch (mevp->me_type) {
  ^~~~~~
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_WRITE' not handled in switch [-Werror=switch]
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_TIMER' not handled in switch [-Werror=switch]
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_SIGNAL' not handled in switch [-Werror=switch]

I guess it just needs a default case?

jhb added a commit: rGd7e2c1479ccf: bhyve: Add support for EVFILT_VNODE mevents..Aug 12 2021, 5:03 PM