Page MenuHomeFreeBSD

bhyve: Add support for EVFILT_VNODE mevents.
ClosedPublic

Authored by jhb on May 27 2021, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 1:15 PM
Unknown Object (File)
Thu, Mar 21, 1:15 PM
Unknown Object (File)
Thu, Mar 21, 1:15 PM
Unknown Object (File)
Wed, Mar 20, 12:34 PM
Unknown Object (File)
Feb 19 2024, 7:27 PM
Unknown Object (File)
Feb 12 2024, 4:01 PM
Unknown Object (File)
Jan 25 2024, 1:53 AM
Unknown Object (File)
Dec 25 2023, 11:12 PM

Details

Summary

This allows registering an event to watch for changes to a file's
attributes. This is a bit imperfect as it would be nice to have a way
to determine if an fd can use EVFILT_VNODE successfully. mevent's
current structure does not permit that and a failure to register a
single kevent impacts several other kevents.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 2 2021, 4:01 PM
This revision was automatically updated to reflect the committed changes.
arichardson added inline comments.
usr.sbin/bhyve/mevent.c
189

GCC appears to be complaining about this:

/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_READ' not handled in switch [-Werror=switch]
  switch (mevp->me_type) {
  ^~~~~~
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_WRITE' not handled in switch [-Werror=switch]
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_TIMER' not handled in switch [-Werror=switch]
/exports/users/alr48/sources/freebsd/usr.sbin/bhyve/mevent.c:188:2: error: enumeration value 'EVF_SIGNAL' not handled in switch [-Werror=switch]

I guess it just needs a default case?