Change mevent_add*() to synchronously add the new kevent. This
permits reporting event registration failures to the caller and avoids
failing the registration of other, unrelated events queued up in the
same batch.
Details
Details
- Reviewers
grehan markj - Group Reviewers
bhyve - Commits
- rG909459c2eda4: bhyve: Register new kevents synchronously.
rGe8424e2947dd: bhyve: Register new kevents synchronously.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
usr.sbin/bhyve/mevent.c | ||
---|---|---|
465 | Perhaps assert that no error occurred, or cast the return value away. |
usr.sbin/bhyve/mevent.c | ||
---|---|---|
465 | bhyve is pretty consistent about assuming no errors from mutexes, condvars, and once and not using either void casts or assertions of that (e.g. there's a once in block_if.c), so I think this is consistent with the rest of bhyve. |