Page MenuHomeFreeBSD

bhyve: Register new kevents synchronously.
ClosedPublic

Authored by jhb on May 27 2021, 1:24 PM.
Tags
None
Referenced Files
F81794335: D30502.diff
Sun, Apr 21, 2:21 PM
Unknown Object (File)
Thu, Apr 18, 3:40 PM
Unknown Object (File)
Tue, Apr 16, 12:31 PM
Unknown Object (File)
Fri, Apr 12, 3:59 PM
Unknown Object (File)
Mar 21 2024, 1:13 PM
Unknown Object (File)
Mar 21 2024, 1:13 PM
Unknown Object (File)
Mar 21 2024, 1:13 PM
Unknown Object (File)
Mar 20 2024, 12:33 PM

Details

Summary

Change mevent_add*() to synchronously add the new kevent. This
permits reporting event registration failures to the caller and avoids
failing the registration of other, unrelated events queued up in the
same batch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39506
Build 36395: arc lint + arc unit

Event Timeline

jhb requested review of this revision.May 27 2021, 1:24 PM
markj added a subscriber: markj.
markj added inline comments.
usr.sbin/bhyve/mevent.c
465

Perhaps assert that no error occurred, or cast the return value away.

This revision is now accepted and ready to land.Jun 2 2021, 3:58 PM
usr.sbin/bhyve/mevent.c
465

bhyve is pretty consistent about assuming no errors from mutexes, condvars, and once and not using either void casts or assertions of that (e.g. there's a once in block_if.c), so I think this is consistent with the rest of bhyve.

This revision was automatically updated to reflect the committed changes.