LGTM.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 18 2019
Sep 15 2019
Sep 5 2019
Sep 4 2019
Sep 3 2019
Would like a different @releng member to take a look if possible, but the change looks reasonable to me.
Aug 31 2019
Remove unused field.
Fix accounting for NumFree.
Fixed a couple of bugs.
Aug 30 2019
Aug 26 2019
Aug 25 2019
Remove D21408 portion of change.
Aug 24 2019
@markj -- do you have some suggestion on how should we test subr_compressor.c changes?
Fix subr_compressor.c.
Aug 23 2019
Aug 22 2019
Aug 21 2019
Aug 20 2019
In D21186#463637, @ota_j.email.ne.jp wrote:The change looks reasonable based on PPP protocol and comparison to existing zlib code.
I didn't know ng_deflate was for ppp.
I was curious how others implemented and found that NetBSD, OpenBSD, and Linux uses Z_PACKET_FLUSH as well, interestingly.
I never looked at ppp implementation and didn't know all others have same base code along with modified zlib.
I am no longer sure if Z_PACKET_FLUSH was FreeBSD original implementation.
Aug 19 2019
Aug 18 2019
Aug 17 2019
Aug 16 2019
Assert that the empty block actually exists.
Undo unrelated space change.
Aug 15 2019
Aug 14 2019
Aug 13 2019
Remove bogus inflateInit().
Address reviewer comments.
Aug 12 2019
(Hopefully have fixed all issues I have found so far).
Aug 11 2019
Aug 8 2019
I have tested with 'dtrace -lv' which will exercise this codepath and confirmed that it worked fine after change.
Refresh patch.
Whoops, this should be committed already according to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21519#c18 .
Properly initialize zstream structure.
Aug 7 2019
+markj for DTrace.
Looks mostly fine to me. I think you don't really need to set zalloc to zcalloc_nowait as the default zcalloc is zcalloc_nowait.
Rebase over D21156.