Page MenuHomeFreeBSD
Differential D21408

GZIO to update zlib version 1.0.4 to 1.2.11.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Aug 24 2019, 10:44 PM.

Details

Reviewers
markj
delphij
emaste
Commits
rS351477: GZIO: Update to use zlib 1.2.11.
Summary

Use ZLIB's crc32() function.

We need this change before D21375.

Test Plan

% sysctl kern.compress_user_cores=1
% top
% kill -6 <top's pid>
% gzip -d top.core.gz

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj added inline comments.Aug 25 2019, 1:38 AM
sys/kern/subr_compressor.c
121 ↗(On Diff #61245)

Why did you change the level?

ota_j.email.ne.jp updated this revision to Diff 61250.Aug 25 2019, 2:58 AM

Include zutil.h instead of zlib.h in order to pick up OS_CODE and DEF_MEM_LEVEL.

ota_j.email.ne.jp edited the test plan for this revision. (Show Details)Aug 25 2019, 2:59 AM
ota_j.email.ne.jp marked an inline comment as done.Aug 25 2019, 3:02 AM
ota_j.email.ne.jp added inline comments.
sys/kern/subr_compressor.c
121 ↗(On Diff #61245)

This changeset was brought from my initial changeset.
Back in that time, due to some API name conflict and few others, I couldn't include zutil.h.

Our zlib migration committed in CURRENT doesn't have this restriction and I was able to revert back.

delphij accepted this revision.Aug 25 2019, 7:47 AM
This revision is now accepted and ready to land.Aug 25 2019, 7:47 AM
Closed by commit rS351477: GZIO: Update to use zlib 1.2.11. (authored by delphij). · Explain WhyAug 25 2019, 7:51 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS351477: GZIO: Update to use zlib 1.2.11..

Revision Contents
Changeset List

PathPackages
Mhead/sys/kern/subr_compressor.c (10 lines)

Diff 61257

View Options

head/sys/kern/subr_compressor.c

Loading...