Page MenuHomeFreeBSD

DDB_CTF to update zlib version 1.0.4 to 1.2.11
ClosedPublic

Authored by delphij on Wed, Aug 7, 4:45 AM.

Details

Summary

Convert DDB_CTF to use newer version of ZLIB.
This change set was split out of D19706.

Test Plan

TBD - I think D19706 mentions how to test and I will test and update later.

[note from delphij: dtrace -lv would exercise the affected codepath. Confirmed that the new zlib functions were actually called and worked fine]

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

delphij requested changes to this revision.Wed, Aug 7, 5:19 AM

Looks mostly fine to me. I think you don't really need to set zalloc to zcalloc_nowait as the default zcalloc is zcalloc_nowait.

sys/kern/kern_ctf.c
259 ↗(On Diff #60531)

I think this can be omitted now.

This revision now requires changes to proceed.Wed, Aug 7, 5:19 AM

+markj for DTrace.

markj accepted this revision.Wed, Aug 7, 3:25 PM
delphij retitled this revision from DDB_CFT to update zlib version 1.0.4 to 1.2.11 to DDB_CTF to update zlib version 1.0.4 to 1.2.11.Thu, Aug 8, 6:48 AM
delphij edited the summary of this revision. (Show Details)
delphij edited reviewers, added: ota_j.email.ne.jp; removed: delphij.Thu, Aug 8, 7:22 AM
delphij commandeered this revision.
This revision is now accepted and ready to land.Thu, Aug 8, 7:22 AM
delphij updated this revision to Diff 60571.Thu, Aug 8, 7:22 AM

Refresh patch.

This revision now requires review to proceed.Thu, Aug 8, 7:22 AM
delphij accepted this revision.Thu, Aug 8, 7:23 AM
This revision is now accepted and ready to land.Thu, Aug 8, 7:23 AM

I have tested with 'dtrace -lv' which will exercise this codepath and confirmed that it worked fine after change.

delphij edited the test plan for this revision. (Show Details)Thu, Aug 8, 7:27 AM
This revision was automatically updated to reflect the committed changes.