Page MenuHomeFreeBSD
Differential D21176

DDB_CTF to update zlib version 1.0.4 to 1.2.11
ClosedPublic
Actions

Authored by delphij on Aug 7 2019, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 7:20 AM
Unknown Object (File)
Feb 16 2024, 7:20 AM
Unknown Object (File)
Feb 16 2024, 7:20 AM
Unknown Object (File)
Feb 16 2024, 7:20 AM
Unknown Object (File)
Feb 16 2024, 4:21 AM
Unknown Object (File)
Feb 14 2024, 8:00 AM
Unknown Object (File)
Feb 13 2024, 1:56 AM
Unknown Object (File)
Jan 9 2024, 11:19 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
markj
ota_j.email.ne.jp
delphij
Commits
rS350744: Convert DDB_CTF to use newer version of ZLIB.
Summary

Convert DDB_CTF to use newer version of ZLIB.
This change set was split out of D19706.

Test Plan

TBD - I think D19706 mentions how to test and I will test and update later.

[note from delphij: dtrace -lv would exercise the affected codepath. Confirmed that the new zlib functions were actually called and worked fine]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ota_j.email.ne.jp created this revision.Aug 7 2019, 4:45 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 7 2019, 4:45 AM
Harbormaster completed remote builds in B25717: Diff 60531.Aug 7 2019, 4:45 AM
delphij requested changes to this revision.Aug 7 2019, 5:19 AM

Looks mostly fine to me. I think you don't really need to set zalloc to zcalloc_nowait as the default zcalloc is zcalloc_nowait.

sys/kern/kern_ctf.c
259 ↗(On Diff #60531)

I think this can be omitted now.

This revision now requires changes to proceed.Aug 7 2019, 5:19 AM
delphij added a reviewer: markj.Aug 7 2019, 5:20 AM

+markj for DTrace.

markj accepted this revision.Aug 7 2019, 3:25 PM
delphij retitled this revision from DDB_CFT to update zlib version 1.0.4 to 1.2.11 to DDB_CTF to update zlib version 1.0.4 to 1.2.11.Aug 8 2019, 6:48 AM
delphij edited the summary of this revision. (Show Details)
delphij commandeered this revision.Aug 8 2019, 7:22 AM
delphij edited reviewers, added: ota_j.email.ne.jp; removed: delphij.
This revision is now accepted and ready to land.Aug 8 2019, 7:22 AM
delphij updated this revision to Diff 60571.Aug 8 2019, 7:22 AM

Refresh patch.

This revision now requires review to proceed.Aug 8 2019, 7:22 AM
Harbormaster completed remote builds in B25740: Diff 60571.Aug 8 2019, 7:22 AM
delphij accepted this revision.Aug 8 2019, 7:23 AM
This revision is now accepted and ready to land.Aug 8 2019, 7:23 AM
delphij added a comment.Aug 8 2019, 7:26 AM

I have tested with 'dtrace -lv' which will exercise this codepath and confirmed that it worked fine after change.

delphij edited the test plan for this revision. (Show Details)Aug 8 2019, 7:27 AM
Closed by commit rS350744: Convert DDB_CTF to use newer version of ZLIB. (authored by delphij). · Explain WhyAug 8 2019, 7:28 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS350744: Convert DDB_CTF to use newer version of ZLIB..

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
18 lines
4 lines
2 lines

Diff 60572

View Options

head/sys/kern/kern_ctf.c

Loading...
View Options

head/sys/kern/link_elf.c

Loading...
View Options

head/sys/kern/link_elf_obj.c

Loading...