Details
- Reviewers
delphij emaste - Commits
- rS351140: Delete sys/dir.h which was deprecated since 1997.
% make buildworld buildkernel
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.
Original PR suggest visit and fix all of ports. It's been over 20 years since taken out of POSIX mentioned PR, I hope most of ports are sys/dir.h clean.
Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)
I'll ask in the #bsdports channel if anyone there thinks it's necessary.
Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)I'll ask in the #bsdports channel if anyone there thinks it's necessary.
Thank you for explanations.
If FreeBSD foundation has resource to build all of ports, that's the best practice and approach.
Even in FreeBSD src, we can find lots of matches with <sys/dir.h>.
After grepping, I got worried.
The catch is all of them are behind ifdef HAS_DIRENT else cases or in README, configure, or config.h files.
All of them were false positive.
Whoops, this should be committed already according to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=21519#c18 .