Page MenuHomeFreeBSD

Delete sys/dir.h which was deprecated since 1997.
Needs ReviewPublic

Authored by ota_j.email.ne.jp on May 31 2019, 12:43 AM.

Details

Reviewers
delphij
emaste
Summary
Test Plan

% make buildworld buildkernel

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 24615
Build 23398: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp edited the summary of this revision. (Show Details)May 31 2019, 12:44 AM

LGTM.

Should request an exp-run for completeness sake.

What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.

Original PR suggest visit and fix all of ports. It's been over 20 years since taken out of POSIX mentioned PR, I hope most of ports are sys/dir.h clean.

What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.
Original PR suggest visit and fix all of ports. It's been over 20 years since taken out of POSIX mentioned PR, I hope most of ports are sys/dir.h clean.

Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)

I'll ask in the #bsdports channel if anyone there thinks it's necessary.

Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)
I'll ask in the #bsdports channel if anyone there thinks it's necessary.

Thank you for explanations.

If FreeBSD foundation has resource to build all of ports, that's the best practice and approach.
Even in FreeBSD src, we can find lots of matches with <sys/dir.h>.
After grepping, I got worried.
The catch is all of them are behind ifdef HAS_DIRENT else cases or in README, configure, or config.h files.
All of them were false positive.