Page MenuHomeFreeBSD

Update Chinese Pinyin related ports:
ClosedPublic

Authored by delphij on Wed, Aug 7, 7:18 AM.

Details

Summary

chinese/ibus-libpinyin: 1.10.0 -> 1.11.1, enable OpenCC
chinese/libpinyin: 2.2.0 -> 2.3.0
textproc/ibus: 1.5.18 -> 1.5.20, while there also fix pkg-message for Qt

Reviewed: TBD

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

delphij created this revision.Wed, Aug 7, 7:18 AM
delphij set the repository for this revision to rP FreeBSD ports repository.Wed, Aug 7, 7:19 AM
delphij added a reviewer: henry.hu.sh_gmail.com.
lichray_gmail.com accepted this revision.Wed, Aug 7, 2:05 PM

LGTM for the libpinyin part unless it breaks fcitx-libpinyin in a way I didn't know.

This revision is now accepted and ready to land.Wed, Aug 7, 2:05 PM
henry.hu.sh_gmail.com requested changes to this revision.Mon, Aug 12, 2:32 AM

With a minor change, the updated ibus-libpinyin works.

chinese/ibus-libpinyin/Makefile
21 ↗(On Diff #60533)

You need to specify that this port needs its glib settings schema to be installed:
GLIB_SCHEMAS= com.github.libpinyin.ibus-libpinyin.gschema.xml

Otherwise, the engine crashes when you switch to this engine. I thought that it worked before, so I'm not sure what's the problem.

With this line, the corresponding line in pkg-plist can be removed.

This revision now requires changes to proceed.Mon, Aug 12, 2:32 AM
delphij updated this revision to Diff 60710.Tue, Aug 13, 5:22 AM

Address reviewer comments.

delphij marked an inline comment as done.Tue, Aug 13, 5:22 AM
This revision is now accepted and ready to land.Thu, Aug 15, 12:03 AM
This revision was automatically updated to reflect the committed changes.