Page MenuHomeFreeBSD
Feed Advanced Search

Aug 10 2023

jfree added a comment to D41379: syslogd: unlink() -> unlinkat().

Can you use our funlinkat() instead of keeping track of the directory descriptor?

Aug 10 2023, 11:24 PM
jfree updated the diff for D41377: syslogd: Move struct definitions into header.

Update after rebase

Aug 10 2023, 11:16 PM
jfree updated the diff for D41388: syslogd: Add closelogfiles() function.

Update after rebase

Aug 10 2023, 11:16 PM
jfree updated the diff for D41376: syslogd: Fix sizeof() styling.

Update after rebase

Aug 10 2023, 11:14 PM
jfree updated the diff for D41375: syslogd: Move action parsing into its own function.

Update after rebase

Aug 10 2023, 11:14 PM
jfree updated the diff for D41374: syslogd: Move selector parsing into its own function.

Update after rebase

Aug 10 2023, 11:13 PM
jfree updated the diff for D41373: syslogd: Move prop_filter allocation into function.

Address Mark's comments

Aug 10 2023, 11:12 PM
jfree updated the diff for D41371: syslogd: Do not print bad data.

Update after rebase

Aug 10 2023, 11:12 PM
jfree updated the diff for D41370: syslogd: Merge loops.

Update after rebase

Aug 10 2023, 11:11 PM
jfree updated the diff for D41369: syslogd: Use process descriptors.

Update after rebase

Aug 10 2023, 11:11 PM
jfree updated the diff for D41368: syslogd: Simplify filed structure.

Update after rebase

Aug 10 2023, 11:10 PM
jfree updated the diff for D41367: syslogd: Style fixes.

Update after rebase

Aug 10 2023, 11:10 PM
jfree updated the diff for D41366: syslogd: Simplify property filters.

Update after rebase

Aug 10 2023, 11:10 PM
jfree updated the diff for D41365: syslogd: Clean up allowedpeer structure.

Update after rebase

Aug 10 2023, 11:08 PM
jfree updated the diff for D41364: syslogd: Only use peerlist during flag parsing.

Address Mark's comments

Aug 10 2023, 11:07 PM
jfree requested review of D41416: syslogd: Use boolean reload parameter for init().
Aug 10 2023, 11:05 PM
jfree requested review of D41415: syslogd: Do not reap child processes.
Aug 10 2023, 11:02 PM
jfree updated the diff for D41363: syslogd: Centralize operations into a kevent loop.

Address Mark's suggestions

Aug 10 2023, 11:01 PM
jfree updated the diff for D41362: syslogd: Replace int with bool, where applicable.

Update after rebase

Aug 10 2023, 11:00 PM
jfree updated the diff for D41360: syslogd: Move fhead under filed struct declaration.

Update after rebase

Aug 10 2023, 11:00 PM
jfree updated the diff for D41359: syslogd: Remove addfile() and free up some memory.

Update after rebase

Aug 10 2023, 10:59 PM
jfree updated the summary of D41358: syslogd: Read configuration outside of init loop.
Aug 10 2023, 10:58 PM
jfree updated the diff for D41358: syslogd: Read configuration outside of init loop.

Address Mark's suggestions

Aug 10 2023, 10:58 PM
jfree abandoned D41378: syslogd: Fix prop_filter memory leak.
Aug 10 2023, 10:08 PM
jfree abandoned D41372: syslogd: Always support recursive config includes.
Aug 10 2023, 9:42 PM
jfree abandoned D41389: syslogd: Watch piped procdescs in kqueue.
Aug 10 2023, 6:04 PM
jfree abandoned D41361: syslogd: Reduce INET/INET6 ifdef cruft.
Aug 10 2023, 4:51 PM
jfree added a comment to D41361: syslogd: Reduce INET/INET6 ifdef cruft.

Did you test compiling with WITHOUT_INET_SUPPORT=or WITHOUT_INET6_SUPPORT= defined? I suspect it will fail, because the #include <netinet/in.h> at the beginning of syslogd is still conditional on INET or INET6 being defined. While the ifdefs are ugly, I'm not sure we can do much better without adding some dummy definitions to replace those in netinet/in.h.

Aug 10 2023, 3:41 PM
jfree added inline comments to D41361: syslogd: Reduce INET/INET6 ifdef cruft.
Aug 10 2023, 3:09 PM

Aug 9 2023

jfree updated the diff for D41401: ttymsg: Create ttymsgat().
  • Remove style(9) changes
  • Check for blocking fd
Aug 9 2023, 9:07 PM
jfree updated the diff for D41403: syslogd: Create regression tests.

Fix spelling mistakes and update to-do list

Aug 9 2023, 8:51 PM
jfree requested review of D41403: syslogd: Create regression tests.
Aug 9 2023, 8:33 PM
jfree requested review of D41402: casper/cap_net: Expose pack/unpack functions.
Aug 9 2023, 8:30 PM
jfree requested review of D41401: ttymsg: Create ttymsgat().
Aug 9 2023, 8:29 PM
jfree added a comment to D41385: syslogd: Rearrange syslogd.c.

I'm not a big fan of reordering functions like this, since that makes git blame quite useless for little gain. In general this kind of commit should come at the end of a patch stack if at all. If it's too painful to reorder it then ok, just something to keep in mind for next time.

Aug 9 2023, 8:02 PM
jfree added inline comments to D41363: syslogd: Centralize operations into a kevent loop.
Aug 9 2023, 7:25 PM
jfree added inline comments to D41358: syslogd: Read configuration outside of init loop.
Aug 9 2023, 7:16 PM
jfree added a comment to D41369: syslogd: Use process descriptors.

Process descriptors for piped processes are registered with kevent() in this patch:

Aug 9 2023, 12:06 AM
jfree requested review of D41389: syslogd: Watch piped procdescs in kqueue.
Aug 9 2023, 12:03 AM
jfree requested review of D41388: syslogd: Add closelogfiles() function.
Aug 9 2023, 12:02 AM

Aug 8 2023

jfree updated the summary of D41376: syslogd: Fix sizeof() styling.
Aug 8 2023, 4:40 PM
jfree requested review of D41385: syslogd: Rearrange syslogd.c.
Aug 8 2023, 4:39 PM
jfree requested review of D41384: syslogd: Isolate parsing code.
Aug 8 2023, 4:38 PM
jfree requested review of D41383: syslogd: Isolate logging code.
Aug 8 2023, 4:37 PM
jfree requested review of D41382: syslogd: Isolate configuration code.
Aug 8 2023, 4:37 PM
jfree requested review of D41381: syslogd: Pre-open null file descriptor.
Aug 8 2023, 4:36 PM
jfree requested review of D41380: syslogd: Do not open console descriptor.
Aug 8 2023, 4:35 PM
jfree requested review of D41379: syslogd: unlink() -> unlinkat().
Aug 8 2023, 4:34 PM
jfree requested review of D41378: syslogd: Fix prop_filter memory leak.
Aug 8 2023, 4:33 PM
jfree requested review of D41377: syslogd: Move struct definitions into header.
Aug 8 2023, 4:32 PM
jfree added a comment to D41362: syslogd: Replace int with bool, where applicable.

The needdofsync global variable was initialized as true, when it should be false. Fix this.

We may want to just leave the 0/false globals without explicit initialization.

Aug 8 2023, 3:51 PM
jfree requested review of D41376: syslogd: Fix sizeof() styling.
Aug 8 2023, 3:40 PM
jfree requested review of D41375: syslogd: Move action parsing into its own function.
Aug 8 2023, 3:39 PM
jfree requested review of D41374: syslogd: Move selector parsing into its own function.
Aug 8 2023, 3:38 PM
jfree requested review of D41373: syslogd: Move prop_filter allocation into function.
Aug 8 2023, 3:37 PM
jfree requested review of D41372: syslogd: Always support recursive config includes.
Aug 8 2023, 3:36 PM
jfree requested review of D41371: syslogd: Do not print bad data.
Aug 8 2023, 3:35 PM
jfree requested review of D41370: syslogd: Merge loops.
Aug 8 2023, 3:34 PM
jfree requested review of D41369: syslogd: Use process descriptors.
Aug 8 2023, 3:33 PM
jfree requested review of D41368: syslogd: Simplify filed structure.
Aug 8 2023, 3:32 PM
jfree requested review of D41367: syslogd: Style fixes.
Aug 8 2023, 3:31 PM
jfree requested review of D41366: syslogd: Simplify property filters.
Aug 8 2023, 3:30 PM
jfree requested review of D41365: syslogd: Clean up allowedpeer structure.
Aug 8 2023, 3:25 PM
jfree requested review of D41364: syslogd: Only use peerlist during flag parsing.
Aug 8 2023, 3:23 PM
jfree requested review of D41363: syslogd: Centralize operations into a kevent loop.
Aug 8 2023, 3:22 PM
jfree updated the diff for D41361: syslogd: Reduce INET/INET6 ifdef cruft.

Update diff with context

Aug 8 2023, 3:19 PM
jfree updated the diff for D41360: syslogd: Move fhead under filed struct declaration.

Update diff with context.

Aug 8 2023, 3:19 PM
jfree updated the diff for D41359: syslogd: Remove addfile() and free up some memory.

Update diff with context

Aug 8 2023, 3:18 PM
jfree updated the diff for D41358: syslogd: Read configuration outside of init loop.

Update diff with context

Aug 8 2023, 3:18 PM
jfree updated the diff for D41357: syslogd: Fix fd type, add enum for filed types.

Update diff with context.

Aug 8 2023, 3:17 PM
jfree added a comment to D41362: syslogd: Replace int with bool, where applicable.

In future when uploading patches via the web interface please generate them with -U99999 so that Phabricator can show full context (see https://wiki.freebsd.org/Phabricator for details)

Aug 8 2023, 3:16 PM
jfree updated the diff for D41362: syslogd: Replace int with bool, where applicable.

The needdofsync global variable was initialized as true, when it should be false. Fix this.

Aug 8 2023, 3:15 PM
jfree requested review of D41362: syslogd: Replace int with bool, where applicable.
Aug 8 2023, 3:02 PM
jfree requested review of D41361: syslogd: Reduce INET/INET6 ifdef cruft.
Aug 8 2023, 3:00 PM
jfree requested review of D41360: syslogd: Move fhead under filed struct declaration.
Aug 8 2023, 2:57 PM
jfree requested review of D41359: syslogd: Remove addfile() and free up some memory.
Aug 8 2023, 2:56 PM
jfree requested review of D41358: syslogd: Read configuration outside of init loop.
Aug 8 2023, 2:55 PM
jfree requested review of D41357: syslogd: Fix fd type, add enum for filed types.
Aug 8 2023, 2:54 PM

Jul 28 2023

jfree updated the diff for D40682: tests: Add ktrace capability violation test cases.

Fix formatting issue in license text

Jul 28 2023, 4:07 PM · capsicum

Jul 21 2023

jfree archived P596 parent --> libcasper.
Jul 21 2023, 10:03 PM
jfree edited P596 parent --> libcasper.
Jul 21 2023, 9:41 PM
jfree created P596 parent --> libcasper.
Jul 21 2023, 9:36 PM

Jun 28 2023

jfree updated the diff for D40790: kern_sig.c: Move SIG_FOREACH into signalvar.h.

Move SIG_FOREACH() into an #ifdef _KERNEL.

Jun 28 2023, 9:42 PM
jfree added inline comments to D40790: kern_sig.c: Move SIG_FOREACH into signalvar.h.
Jun 28 2023, 9:28 PM
jfree updated the diff for D40218: timerfd: Add manual page.

Fix formatting in HISTORY section thanks to @gbe.

Jun 28 2023, 8:24 PM · manpages
jfree added a comment to D38459: timerfd: Add native support for Linux's timerfd.

I would like to get this patch committed before the 14.0 freeze in August. I am personally in favor of making these syscalls, but I'd like some notice if we're not going this route.

Jun 28 2023, 8:01 PM · linuxkpi, Linux Emulation
jfree updated the diff for D38459: timerfd: Add native support for Linux's timerfd.

Add brief comments explaining each of the tfd_jumped macros.

Jun 28 2023, 7:57 PM · linuxkpi, Linux Emulation
jfree requested review of D40791: signalfd: Add native support for Linux's signalfd.
Jun 28 2023, 7:52 PM
jfree requested review of D40790: kern_sig.c: Move SIG_FOREACH into signalvar.h.
Jun 28 2023, 7:42 PM
jfree archived P591 Page fault with SIGCHLD.
Jun 28 2023, 1:28 AM
jfree created P591 Page fault with SIGCHLD.
Jun 28 2023, 12:59 AM

Jun 22 2023

jfree archived P574 ktrace exec CAPFAIL_VFS.
Jun 22 2023, 4:01 PM
jfree archived P576 ktrace: unzip(1).
Jun 22 2023, 4:01 PM
jfree archived P577 ktrace: syslogd(8).
Jun 22 2023, 4:01 PM
jfree created P582 tty panic.
Jun 22 2023, 3:13 PM

Jun 20 2023

jfree updated the diff for D40682: tests: Add ktrace capability violation test cases.

Use cap_svflags instead of cap_flags when determining kernel ABI with syscallabi().

Jun 20 2023, 10:40 PM · capsicum
jfree updated the diff for D40680: ktrace: Record namei violations with KTR_CAPFAIL.

Change NI_LCF_STRICTRELATIVE to NI_LCF_STRICTREL where applicable.

Jun 20 2023, 10:19 PM · capsicum
jfree requested review of D40682: tests: Add ktrace capability violation test cases.
Jun 20 2023, 10:10 PM · capsicum
jfree requested review of D40681: ktrace: Record socket violations with KTR_CAPFAIL.
Jun 20 2023, 10:09 PM · capsicum
jfree requested review of D40680: ktrace: Record namei violations with KTR_CAPFAIL.
Jun 20 2023, 10:08 PM · capsicum