Page MenuHomeFreeBSD
Differential D40218

timerfd: Add manual page
ClosedPublic
Actions

Authored by jfree on May 22 2023, 10:02 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:17 PM
Unknown Object (File)
Sat, Apr 20, 2:19 AM
Unknown Object (File)
Thu, Apr 18, 5:50 AM
Unknown Object (File)
Thu, Apr 18, 5:40 AM
Unknown Object (File)
Thu, Apr 18, 5:27 AM
Unknown Object (File)
Thu, Apr 18, 4:20 AM
Unknown Object (File)
Thu, Apr 18, 4:19 AM
Unknown Object (File)
Thu, Apr 18, 4:17 AM
View All 54 Files
Subscribers
grahamperrin
imp

Details

Reviewers
gbe
grahamperrin
imp
Commits
rG8544651dc509: timerfd: Add manual page.
Summary

This manual page accompanies the timerfd system calls.

https://reviews.freebsd.org/D38459

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree created this revision.May 22 2023, 10:02 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2023, 10:02 PM
jfree requested review of this revision.May 22 2023, 10:02 PM
gbe added a comment.Jun 18 2023, 5:47 AM

Just a little style for the mail addresses in the HISTORY section, otherwise LGTM. Can't speak for the technical details.

lib/libc/sys/timerfd.2
329

I would add an '.An -nosplit' after .Sh HISTORY.

333

On a separate line

.An Dmitry Chagin Aq Mt dchagin@FreeBSD.org

335

On a separaate line

.An Jake Freeland Aq Mt jfree@FreeBSD.org

jfree updated this revision to Diff 123925.Jun 28 2023, 8:23 PM

Fix formatting in HISTORY section thanks to @gbe.

grahamperrin requested changes to this revision.Jun 29 2023, 3:47 AM
grahamperrin added a subscriber: grahamperrin.
grahamperrin added inline comments.
lib/libc/sys/timerfd.2
166

Might Normally or Typically be better?

(Because regularity can be time-related, i.e. "like clockwork".)

235
273
287
This revision now requires changes to proceed.Jun 29 2023, 3:47 AM
jfree updated this revision to Diff 126480.Aug 24 2023, 5:12 PM
jfree marked 4 inline comments as done.

Address @grahamperrin's comments.

imp accepted this revision.Aug 24 2023, 8:10 PM

Looks good to my eye. Looks like all the comments have been addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2023, 8:31 PM
Closed by commit rG8544651dc509: timerfd: Add manual page. (authored by jfree, committed by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG8544651dc509: timerfd: Add manual page..

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
4 lines
340 lines

Diff 126490

View Options

lib/libc/sys/Makefile.inc

Loading...
View Options

lib/libc/sys/timerfd.2

Loading...