Page MenuHomeFreeBSD

syslogd: Fix sizeof() styling
ClosedPublic

Authored by jfree on Aug 8 2023, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 4:05 PM
Unknown Object (File)
Nov 29 2024, 10:27 PM
Unknown Object (File)
Nov 27 2024, 7:23 PM
Unknown Object (File)
Oct 26 2024, 7:47 AM
Unknown Object (File)
Oct 21 2024, 5:24 AM
Unknown Object (File)
Oct 21 2024, 5:20 AM
Unknown Object (File)
Oct 21 2024, 5:20 AM
Unknown Object (File)
Oct 21 2024, 5:14 AM
Subscribers

Details

Summary

Use parentheses when applying sizeof() per style(9).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

when calling sizeof()

We don't really "call" sizeof (why parens aren't needed) so perhaps "with sizeof()"

This revision is now accepted and ready to land.Aug 8 2023, 3:43 PM

when calling sizeof()

We don't really "call" sizeof (why parens aren't needed) so perhaps "with sizeof()"

Right, sizeof is an operator, so "when applying sizeof" would be more appropriate if you wanted to keep the original sentence structure.

jfree edited the summary of this revision. (Show Details)

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:14 PM
This revision is now accepted and ready to land.Aug 11 2023, 3:00 PM

Update to avoid rebase conflict

This revision now requires review to proceed.Aug 11 2023, 6:22 PM
This revision is now accepted and ready to land.Aug 14 2023, 2:23 PM
This revision was automatically updated to reflect the committed changes.