Paths

Table of Contentst

Differential D41380

syslogd: Do not open console descriptor
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 4:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 14, 4:19 AM

	Unknown Object (File)
	Thu, Nov 13, 4:45 AM

	Unknown Object (File)
	Wed, Nov 12, 7:20 PM

	Unknown Object (File)
	Thu, Nov 6, 5:09 AM

	Unknown Object (File)
	Tue, Nov 4, 5:47 AM

	Unknown Object (File)
	Tue, Oct 28, 11:30 PM

	Unknown Object (File)
	Sun, Oct 26, 11:14 AM

	Unknown Object (File)
	Sun, Oct 26, 4:28 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rGc3175a6e1c5a: syslogd: Do not open console descriptor

Summary

Setup consfile filed for logging while Initialized is false, but do not
bother opening the console. Close console/tty descriptors after parsing,
as well. The ttymsg() function will re-open these descriptors for us.

Also, remove references to the ctty global variable since it will always
be _PATH_CONSOLE.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Aug 8 2023, 4:35 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 4:35 PM

jfree requested review of this revision.Aug 8 2023, 4:35 PM

jfree added a parent revision: D41379: syslogd: unlink() -> unlinkat().

jfree added a child revision: D41381: syslogd: Pre-open null file descriptor.

markj accepted this revision.Aug 11 2023, 3:04 PM

This revision is now accepted and ready to land.Aug 11 2023, 3:04 PM

Update after rebase

This revision now requires review to proceed.Aug 12 2023, 3:49 AM

markj accepted this revision.Aug 14 2023, 2:25 PM

This revision is now accepted and ready to land.Aug 14 2023, 2:25 PM

Move consfile setup before waitdaemon() to align with nulldesc ordering in https://reviews.freebsd.org/D41381

This revision now requires review to proceed.Aug 14 2023, 5:51 PM

Update after peerlist rebase, adding pidfile_remove() in cleanup

jfree updated this revision to Diff 126343.Aug 21 2023, 10:46 PM

jfree retitled this revision from syslogd: Pre-open console file descriptor to syslogd: Do not open consfile descriptor.

jfree edited the summary of this revision. (Show Details)

Close console/tty descriptors while config parsing.

markj accepted this revision.Aug 23 2023, 2:44 PM

This revision is now accepted and ready to land.Aug 23 2023, 2:44 PM

Closed by commit rGc3175a6e1c5a: syslogd: Do not open console descriptor (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:54 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc3175a6e1c5a: syslogd: Do not open console descriptor.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

34 lines

Diff 127948

usr.sbin/syslogd/syslogd.c

Loading...