syslogd: Watch for dead pipe processes

[jfree]

Summary

For each new pipe process, add its process descriptor into the kqueue
with the EVFILT_PROCDESC filter and NOTE_EXIT event. When the pipe
process exits, the main kqueue loop will catch this, logging exit errors
and cleaning up the pipe process' filed node.

[jfree]

Add boolean reload parameter to close_filed(). When set to true, remove kevents that reference the filed.

[jfree]

Remove reload parameter in close_filed(). Move kqueue deletion into closelogfiles() instead.

[jfree]

Update after rebase conflicts

[markj]

usr.sbin/syslogd/syslogd.c

2499

What's the point of deleting the kevent if we're about to close the fd anyway? Does that simplify cleanup somehow?

[jfree]

usr.sbin/syslogd/syslogd.c

2499

What's the point of deleting the kevent if we're about to close the fd anyway? Does that simplify cleanup somehow?

If we're reloading, it is possible that piped processes are still alive. In init(), this closelogfiles() is called and all fileds are freed. If we don't remove the piped process' kevent from the kqueue, then EVFILT_PROCDESC will be triggered upon the procdesc closure in close_filed(). Back in main(), the EVFILT_PROCDESC will attempt to call close_filed() again with an invalid, freed filed (stored in its udata).

[jfree]

Update to avoid rebase conflicts.

[jfree]

Bumping this