Page MenuHomeFreeBSD
Differential D41366

syslogd: Simplify property filters
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:30 PM.
Tags
None
Referenced Files
F174662430: D41366.id.diff
Mon, Oct 5, 1:12 AM
Unknown Object (File)
Sun, Oct 4, 7:32 AM
Unknown Object (File)
Sun, Oct 4, 4:57 AM
Unknown Object (File)
Sat, Oct 3, 10:02 PM
Unknown Object (File)
Sat, Oct 3, 9:19 AM
Unknown Object (File)
Sat, Oct 3, 7:04 AM
Unknown Object (File)
Sat, Oct 3, 6:00 AM
Unknown Object (File)
Sat, Oct 3, 3:34 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGfcc1e1777d42: syslogd: Simplify property filters
Summary
  • Use enums for property filter properties and comparisons.
  • Rename property and comparison values.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree created this revision.Aug 8 2023, 3:30 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:30 PM
jfree requested review of this revision.Aug 8 2023, 3:30 PM
jfree added a parent revision: D41365: syslogd: Clean up allowedpeer structure.
jfree added a child revision: D41367: syslogd: Style fixes.
markj accepted this revision.Aug 9 2023, 7:21 PM

Because C enums are integer-sized, this makes struct prop_filter a bit fatter, but that's ok.

usr.sbin/syslogd/syslogd.c
237

FILT_CMP_* now starts from 0 instead of 1, but I think that's fine...

1571

This can be:

default:
    __unreachable();

(FILT_CMP_REGEX is handled above.)

This revision is now accepted and ready to land.Aug 9 2023, 7:21 PM
jfree updated this revision to Diff 125837.Aug 10 2023, 11:10 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:10 PM
markj accepted this revision.Aug 11 2023, 2:50 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM
Closed by commit rGfcc1e1777d42: syslogd: Simplify property filters (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGfcc1e1777d42: syslogd: Simplify property filters.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
101 lines

Diff 127942

View Options

usr.sbin/syslogd/syslogd.c

Loading...