Page MenuHomeFreeBSD

syslogd: Simplify property filters
ClosedPublic

Authored by jfree on Aug 8 2023, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 16, 11:22 PM
Unknown Object (File)
Aug 30 2025, 8:45 PM
Unknown Object (File)
Aug 26 2025, 1:10 AM
Unknown Object (File)
Aug 20 2025, 2:06 PM
Unknown Object (File)
Aug 14 2025, 10:28 PM
Unknown Object (File)
Aug 14 2025, 10:17 PM
Unknown Object (File)
Aug 4 2025, 2:20 PM
Unknown Object (File)
Aug 3 2025, 8:35 AM
Subscribers

Details

Summary
  • Use enums for property filter properties and comparisons.
  • Rename property and comparison values.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Because C enums are integer-sized, this makes struct prop_filter a bit fatter, but that's ok.

usr.sbin/syslogd/syslogd.c
237

FILT_CMP_* now starts from 0 instead of 1, but I think that's fine...

1571

This can be:

default:
    __unreachable();

(FILT_CMP_REGEX is handled above.)

This revision is now accepted and ready to land.Aug 9 2023, 7:21 PM
This revision now requires review to proceed.Aug 10 2023, 11:10 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM
This revision was automatically updated to reflect the committed changes.