Page MenuHomeFreeBSD

syslogd: Move struct definitions into header
AbandonedPublic

Authored by jfree on Aug 8 2023, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 11:26 AM
Unknown Object (File)
Fri, Nov 1, 3:17 AM
Unknown Object (File)
Mon, Oct 21, 3:36 AM
Unknown Object (File)
Mon, Oct 21, 3:33 AM
Unknown Object (File)
Oct 6 2024, 3:41 PM
Unknown Object (File)
Sep 24 2024, 9:05 AM
Unknown Object (File)
Sep 2 2024, 5:20 AM
Unknown Object (File)
Sep 2 2024, 5:20 AM
Subscribers

Details

Reviewers
markj
emaste
Summary
Extract the struct definitions from the source syslogd.c file and move
them into an isolated syslogd.h header file.

This change facilitates the compartmentalization of syslogd into
separate files.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I'm ok with this, a general comment is just that we should seek to minimize syslogd.h, i.e., try to ensure it only contains stuff that really needs to be shared. For example, I'm pretty sure casper doesn't need RCVBUF_MINSIZE?

This revision is now accepted and ready to land.Aug 11 2023, 3:02 PM

I'm ok with this, a general comment is just that we should seek to minimize syslogd.h, i.e., try to ensure it only contains stuff that really needs to be shared. For example, I'm pretty sure casper doesn't need RCVBUF_MINSIZE?

A later patch will split syslogd into multiple files for configuration parsing, message parsing, and log parsing. This is all needed there.