Page MenuHomeFreeBSD

syslogd: Merge loops
ClosedPublic

Authored by jfree on Aug 8 2023, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 12:09 AM
Unknown Object (File)
Wed, Oct 15, 12:09 AM
Unknown Object (File)
Wed, Oct 15, 12:09 AM
Unknown Object (File)
Wed, Oct 15, 12:04 AM
Unknown Object (File)
Tue, Oct 14, 11:44 PM
Unknown Object (File)
Mon, Oct 13, 3:14 PM
Unknown Object (File)
Sun, Oct 12, 3:03 AM
Unknown Object (File)
Tue, Sep 30, 1:47 PM
Subscribers

Details

Summary
Merge the two loops that traverse the global filed queue. Both loops'
actions are not dependent on the other, so combining them is safe.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 9 2023, 7:37 PM
This revision now requires review to proceed.Aug 10 2023, 11:11 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:56 PM

so combining them is safe

I think it's not only safe, but more clear/obvious with your change assuming fileds have no (can have no) reference between them.

This revision was automatically updated to reflect the committed changes.