Page MenuHomeFreeBSD
Differential D41370

syslogd: Merge loops
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 26, 4:20 PM
Unknown Object (File)
Wed, Nov 26, 1:47 AM
Unknown Object (File)
Tue, Nov 25, 5:17 AM
Unknown Object (File)
Sun, Nov 23, 9:59 AM
Unknown Object (File)
Sat, Nov 22, 6:33 PM
Unknown Object (File)
Sat, Nov 22, 3:38 AM
Unknown Object (File)
Fri, Nov 21, 7:57 PM
Unknown Object (File)
Fri, Nov 21, 7:34 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGbbde787c6668: syslogd: Merge loops
Summary
Merge the two loops that traverse the global filed queue. Both loops'
actions are not dependent on the other, so combining them is safe.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree created this revision.Aug 8 2023, 3:34 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:34 PM
jfree requested review of this revision.Aug 8 2023, 3:34 PM
jfree added a parent revision: D41369: syslogd: Use process descriptors.
jfree added a child revision: D41371: syslogd: Do not print bad data.
markj accepted this revision.Aug 9 2023, 7:37 PM
This revision is now accepted and ready to land.Aug 9 2023, 7:37 PM
jfree updated this revision to Diff 125841.Aug 10 2023, 11:11 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:11 PM
markj accepted this revision.Aug 11 2023, 2:56 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:56 PM
jfree added a parent revision: D41415: syslogd: Do not reap child processes.Aug 11 2023, 6:09 PM
jfree removed a parent revision: D41369: syslogd: Use process descriptors.
emaste added a comment.Aug 14 2023, 5:33 PM

so combining them is safe

I think it's not only safe, but more clear/obvious with your change assuming fileds have no (can have no) reference between them.

Closed by commit rGbbde787c6668: syslogd: Merge loops (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGbbde787c6668: syslogd: Merge loops.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
10 lines

Diff 127947

View Options

usr.sbin/syslogd/syslogd.c

Loading...