Page MenuHomeFreeBSD

kern_sig.c: Move SIG_FOREACH into signalvar.h
AcceptedPublic

Authored by jfree on Jun 28 2023, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 3:02 AM
Unknown Object (File)
Mon, Oct 13, 6:43 AM
Unknown Object (File)
Sat, Oct 4, 4:14 PM
Unknown Object (File)
Fri, Oct 3, 7:36 AM
Unknown Object (File)
Sep 16 2025, 12:37 AM
Unknown Object (File)
Sep 13 2025, 12:22 AM
Unknown Object (File)
Sep 11 2025, 9:06 PM
Unknown Object (File)
Sep 5 2025, 5:51 AM
Subscribers

Details

Reviewers
markj
Summary
Make the SIG_FOREACH macro accessible outside of kern_sig.c by moving
it into signalvar.h next to the other sigset_t macros.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree requested review of this revision.Jun 28 2023, 7:42 PM
sys/sys/signalvar.h
154

Presumably you intend to use this elsewhere in the kernel, and not in userspace? If so, these definitions should go into the #ifdef _KERNEL block below: we don't want to inadvertently put new stuff in the userland-visible namespace.

sys/sys/signalvar.h
154

Hm. I was under the impression that everything in this file was stricly for the kernel because it includes the ksiginfo declaration and macros.

I'll move this one into an ifdef _KERNEL, though. Thanks for pointing that out.

jfree marked an inline comment as done.

Move SIG_FOREACH() into an #ifdef _KERNEL.

This revision is now accepted and ready to land.Jun 29 2023, 2:46 PM