Page MenuHomeFreeBSD
Differential D40790

kern_sig.c: Move SIG_FOREACH into signalvar.h
AcceptedPublic
Actions

Authored by jfree on Jun 28 2023, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 24, 10:05 AM
Unknown Object (File)
Mon, Jun 22, 1:10 PM
Unknown Object (File)
Sat, Jun 20, 6:26 PM
Unknown Object (File)
Wed, Jun 17, 11:56 PM
Unknown Object (File)
Wed, Jun 17, 10:38 PM
Unknown Object (File)
Wed, Jun 17, 2:59 AM
Unknown Object (File)
Sat, May 30, 2:23 PM
Unknown Object (File)
Sat, May 30, 1:58 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
markj
Summary
Make the SIG_FOREACH macro accessible outside of kern_sig.c by moving
it into signalvar.h next to the other sigset_t macros.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree created this revision.Jun 28 2023, 7:42 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 28 2023, 7:42 PM
jfree requested review of this revision.Jun 28 2023, 7:42 PM
jfree added a child revision: D40791: signalfd: Add native support for Linux's signalfd.Jun 28 2023, 7:55 PM
markj added inline comments.Jun 28 2023, 8:52 PM
sys/sys/signalvar.h
154

Presumably you intend to use this elsewhere in the kernel, and not in userspace? If so, these definitions should go into the #ifdef _KERNEL block below: we don't want to inadvertently put new stuff in the userland-visible namespace.

jfree added inline comments.Jun 28 2023, 9:28 PM
sys/sys/signalvar.h
154

Hm. I was under the impression that everything in this file was stricly for the kernel because it includes the ksiginfo declaration and macros.

I'll move this one into an ifdef _KERNEL, though. Thanks for pointing that out.

jfree updated this revision to Diff 123932.Jun 28 2023, 9:42 PM
jfree marked an inline comment as done.

Move SIG_FOREACH() into an #ifdef _KERNEL.

markj accepted this revision.Jun 29 2023, 2:46 PM
This revision is now accepted and ready to land.Jun 29 2023, 2:46 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
23 lines
sys/
24 lines

Diff 123932

View Options

sys/kern/kern_sig.c

Loading...
View Options

sys/sys/signalvar.h

Loading...