syslogd: Rearrange syslogd.c
AbandonedPublic
Actions

Authored by jfree on Aug 8 2023, 4:39 PM.

Details

Reviewers

emaste
markj

Summary

Alphabetically order global variables
Remove declarations for static functions
Reorder functions according to static declaration

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 4:39 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 4:39 PM

jfree requested review of this revision.Aug 8 2023, 4:39 PM

jfree added a child revision: D41388: syslogd: Add closelogfiles() function.Aug 9 2023, 12:02 AM

I'm not a big fan of reordering functions like this, since that makes git blame quite useless for little gain. In general this kind of commit should come at the end of a patch stack if at all. If it's too painful to reorder it then ok, just something to keep in mind for next time.

In D41385#942540, @markj wrote:

I'm not a big fan of reordering functions like this, since that makes git blame quite useless for little gain. In general this kind of commit should come at the end of a patch stack if at all. If it's too painful to reorder it then ok, just something to keep in mind for next time.

I concur. I will just drop this one. It'll make rebasing horrible too.
The negatives far outweigh the positives.

jfree removed a child revision: D41388: syslogd: Add closelogfiles() function.Aug 10 2023, 11:15 PM

jfree abandoned this revision.Aug 11 2023, 7:46 PM