Page MenuHomeFreeBSD
Feed Advanced Search

Oct 1 2022

melifaro committed rG7c40e2d5f685: linuxolator: add netlink support (authored by melifaro).
linuxolator: add netlink support
Oct 1 2022, 2:20 PM
melifaro closed D36361: linuxolator: add netlink support.
Oct 1 2022, 2:20 PM
melifaro closed D36002: netlink: add netlink support.
Oct 1 2022, 2:19 PM
melifaro committed rG7e5bf68495cc: netlink: add netlink support (authored by melifaro).
netlink: add netlink support
Oct 1 2022, 2:19 PM
melifaro added inline comments to D36470: ktls: Document requirement of use_flowid for lagg and NIC kTLS.
Oct 1 2022, 11:14 AM

Sep 30 2022

melifaro updated the diff for D36002: netlink: add netlink support.

Address the remaining manpage comments.

Sep 30 2022, 2:15 PM
melifaro added inline comments to D36002: netlink: add netlink support.
Sep 30 2022, 2:14 PM
melifaro updated the diff for D36002: netlink: add netlink support.

Address emaste@ manpage comments.

Sep 30 2022, 2:07 PM
melifaro added inline comments to D36002: netlink: add netlink support.
Sep 30 2022, 1:50 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Use STAILQ mbuf macros in nl_io_queue
  • Update man pages to reflect the comments
Sep 30 2022, 1:49 PM

Sep 29 2022

melifaro added inline comments to D36002: netlink: add netlink support.
Sep 29 2022, 9:37 PM
melifaro added a comment to D36002: netlink: add netlink support.

I’m going to commit this tomorrow, Friday 30, unless there are any objections

Sep 29 2022, 7:39 PM
melifaro updated the diff for D36002: netlink: add netlink support.

Update headers to reflect the comments.

Sep 29 2022, 5:20 PM
melifaro added a comment to D36002: netlink: add netlink support.
In D36002#835201, @imp wrote:

From a licensing point of view, thinks look generally OK (modulo the one different language for the man pages I noticed). My approval is conditional on you fixing or explaining why you used these.
Most of these headers appear to have little creative content
Copying from the RFC is the only possible issue, since each RFC has its own permission statement. Please verify text from there can be copied verbatim.
Otherwise it appears that most of these items are covered by 'only one way to do it' plus 'gotta have these names and values for compatibility' exceptions.

Their "Full Copyright Statement" states that it can be used freely provided their copyright statement has to be included: "provided that the above copyright notice and this paragraph are

included on all such copies and derivative works". I've updated `netlink/netlink.h` to include this header. Does it look right to you?
Sep 29 2022, 5:20 PM
melifaro updated the diff for D36002: netlink: add netlink support.

Address header files feedback.

Sep 29 2022, 3:47 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add basic support for NETLINK_GET_STRICT_CHK
  • Fix getsockopt() for NETLINK_CAP_ACK / NETLINK_EXT_ACK
  • Move interface creation logic to the iface_drivers.c
  • Fix manpage lint errors
Sep 29 2022, 1:37 PM

Sep 28 2022

melifaro added a comment to D36651: if_move: create new ifp instances on each vmove.
In D36651#833505, @kp wrote:

That's an interesting idea, but I'm not clear on what the long-term plan is.
This will work (and might indeed be an improvement) for cloned interfaces, but we'd still have to maintain the previous way of handling things for "real" (e.g. igb0) interfaces as they're moved between vnets.

I worry that we'll end up doing things one way for cloned interfaces, and another for other interfaces, which gives us twice the opportunity for bugs, and half as much testing.

Thank you for the feedback!
Indeed, I should have included the proposal for the physical interfaces.
The primary goal of this change in general is to replace the current mechanism. I'm currently thinking of the following:

  • Slightly re-purpose if_reassign() to perform the same function as vmove_f handler (potentially even use if_reassign() directly even for cloned interfaces)
  • Write the handlers for the "relevant" (e.g. modern, likely to be used in routers/cloud setups) interfaces such as vnet/iflib/mellanox/chelsio
  • Add a deprecation warning with a wiki link, specifying how to report it, to the current cloning method
  • Wait for a couple of months and remove the current cloning method
Sep 28 2022, 3:28 PM
melifaro abandoned D36328: sockets: add SO_RCVBUFFORCE to allow maxsockbuf value bypassing..

Abort in favour of D36746

Sep 28 2022, 3:19 PM
melifaro added a reviewer for D36002: netlink: add netlink support: manpages.
Sep 28 2022, 3:05 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add custom SO_RCVBUF handler
  • Sync to the recent HEAD
  • Add manpage for netlink(4) and a manpage draft for rtnetlink(4).
Sep 28 2022, 3:04 PM
melifaro closed D36747: sockbufs: add sbreserve_locked_limit() with custom maxsockbuf limit..
Sep 28 2022, 10:21 AM
melifaro committed rG7b660faa9e30: sockbufs: add sbreserve_locked_limit() with custom maxsockbuf limit. (authored by melifaro).
sockbufs: add sbreserve_locked_limit() with custom maxsockbuf limit.
Sep 28 2022, 10:21 AM
melifaro closed D36746: protocols: make socket buffers ioctl handler changeable.
Sep 28 2022, 10:21 AM
melifaro committed rGf66968564dd7: protocols: make socket buffers ioctl handler changeable (authored by melifaro).
protocols: make socket buffers ioctl handler changeable
Sep 28 2022, 10:20 AM

Sep 27 2022

melifaro requested review of D36747: sockbufs: add sbreserve_locked_limit() with custom maxsockbuf limit..
Sep 27 2022, 1:57 PM
melifaro added reviewers for D36746: protocols: make socket buffers ioctl handler changeable: glebius, network.
Sep 27 2022, 1:48 PM
melifaro requested review of D36746: protocols: make socket buffers ioctl handler changeable.
Sep 27 2022, 1:47 PM
melifaro committed rG04a32b802ec7: if_epair: refactor interface creation and enqueue code. (authored by melifaro).
if_epair: refactor interface creation and enqueue code.
Sep 27 2022, 1:35 PM
melifaro closed D36689: if_epair: refactor interface creation and enqueue code..
Sep 27 2022, 1:35 PM
melifaro committed rGe437991fc936: netinet6: factor interface addition code to the dedicated function (authored by melifaro).
netinet6: factor interface addition code to the dedicated function
Sep 27 2022, 1:24 PM
melifaro closed D36713: netinet6: factor interface addition code to the dedicated function.
Sep 27 2022, 1:24 PM
melifaro accepted D36727: netinet*: de-void control input IP protocol methods.
Sep 27 2022, 11:03 AM
melifaro accepted D36726: netinet6: retire ip6protosw.h.
Sep 27 2022, 8:44 AM
melifaro accepted D36725: tcp: remove unnecessary include of tcp6_var.h.
Sep 27 2022, 8:42 AM
melifaro accepted D36724: udp: typedef udp tunneling functions to functions, not pointers.
Sep 27 2022, 8:42 AM
melifaro accepted D36723: netinet*: move ipproto_register() and co to ip_var.h and ip6_var.h.
Sep 27 2022, 8:41 AM

Sep 26 2022

melifaro updated the summary of D36713: netinet6: factor interface addition code to the dedicated function.
Sep 26 2022, 1:58 PM
melifaro updated the summary of D36713: netinet6: factor interface addition code to the dedicated function.
Sep 26 2022, 1:55 PM
melifaro requested review of D36713: netinet6: factor interface addition code to the dedicated function.
Sep 26 2022, 1:51 PM
melifaro committed rGf375bf0e6f0b: netinet: pass cred instead of the curthread to ifaddr manipulation funcs. (authored by melifaro).
netinet: pass cred instead of the curthread to ifaddr manipulation funcs.
Sep 26 2022, 1:47 PM
melifaro updated the summary of D36651: if_move: create new ifp instances on each vmove.
Sep 26 2022, 10:24 AM
melifaro updated the test plan for D36651: if_move: create new ifp instances on each vmove.
Sep 26 2022, 10:24 AM
melifaro updated the diff for D36651: if_move: create new ifp instances on each vmove.

Simplify patch.

Sep 26 2022, 10:23 AM

Sep 24 2022

melifaro updated the summary of D36651: if_move: create new ifp instances on each vmove.
Sep 24 2022, 8:43 PM
melifaro updated the diff for D36651: if_move: create new ifp instances on each vmove.

Update patch

Sep 24 2022, 8:42 PM
melifaro updated the summary of D36689: if_epair: refactor interface creation and enqueue code..
Sep 24 2022, 8:24 PM
melifaro requested review of D36689: if_epair: refactor interface creation and enqueue code..
Sep 24 2022, 8:22 PM
melifaro committed rG26c190d2802e: if_clone: add ifc_link_ifp() / ifc_unlink_ifp() to the KPI (authored by melifaro).
if_clone: add ifc_link_ifp() / ifc_unlink_ifp() to the KPI
Sep 24 2022, 8:15 PM
melifaro committed rG9a7c520a7811: ifp: add if_setdescr() / if_freedesrt() methods (authored by melifaro).
ifp: add if_setdescr() / if_freedesrt() methods
Sep 24 2022, 8:15 PM
melifaro updated the diff for D36651: if_move: create new ifp instances on each vmove.

Update patch

Sep 24 2022, 12:58 PM

Sep 22 2022

melifaro added inline comments to D36636: if_clone: migrate some consumers to the new KPI.
Sep 22 2022, 12:33 PM
melifaro closed D36636: if_clone: migrate some consumers to the new KPI.
Sep 22 2022, 12:33 PM
melifaro committed rG91ebcbe02a48: if_clone: migrate some consumers to the new KPI. (authored by melifaro).
if_clone: migrate some consumers to the new KPI.
Sep 22 2022, 12:32 PM
melifaro closed D36632: if_clone: rework cloning KPI.
Sep 22 2022, 10:21 AM
melifaro committed rG09ee0fc023c0: if_clone: rework cloning KPI (authored by melifaro).
if_clone: rework cloning KPI
Sep 22 2022, 10:21 AM
melifaro added inline comments to D36614: epair: deduplicate interface allocation code #1.
Sep 22 2022, 9:36 AM
melifaro committed rG12aeeb91903b: epair: deduplicate interface allocation code #1 (authored by melifaro).
epair: deduplicate interface allocation code #1
Sep 22 2022, 9:34 AM
melifaro closed D36614: epair: deduplicate interface allocation code #1.
Sep 22 2022, 9:34 AM

Sep 21 2022

melifaro updated the test plan for D36651: if_move: create new ifp instances on each vmove.
Sep 21 2022, 6:46 PM
melifaro requested review of D36651: if_move: create new ifp instances on each vmove.
Sep 21 2022, 6:44 PM

Sep 20 2022

melifaro added reviewers for D36636: if_clone: migrate some consumers to the new KPI: network, glebius, kp.
Sep 20 2022, 2:53 PM
melifaro requested review of D36636: if_clone: migrate some consumers to the new KPI.
Sep 20 2022, 2:52 PM
melifaro updated the diff for D36632: if_clone: rework cloning KPI.

add ifc_copyout()

Sep 20 2022, 2:51 PM
melifaro updated the summary of D36632: if_clone: rework cloning KPI.
Sep 20 2022, 12:19 PM
melifaro updated the summary of D36632: if_clone: rework cloning KPI.
Sep 20 2022, 12:15 PM
melifaro requested review of D36632: if_clone: rework cloning KPI.
Sep 20 2022, 11:18 AM

Sep 18 2022

melifaro accepted D36619: Deprecate telnetd.
Sep 18 2022, 12:38 PM

Sep 17 2022

melifaro retitled D36614: epair: deduplicate interface allocation code #1 from epair: deduplicate interface allocation code to epair: deduplicate interface allocation code #1.
Sep 17 2022, 8:57 PM
melifaro updated the diff for D36614: epair: deduplicate interface allocation code #1.

.

Sep 17 2022, 8:54 PM
melifaro requested review of D36614: epair: deduplicate interface allocation code #1.
Sep 17 2022, 8:51 PM

Sep 14 2022

melifaro accepted D36584: ip_output: always increase "cantfrag" stat if ip_fragment() fails.
Sep 14 2022, 11:17 PM

Sep 11 2022

melifaro updated the diff for D36002: netlink: add netlink support.

Clean up headers a bit.

Sep 11 2022, 8:13 PM
melifaro retitled D36529: netstat: make netstat -rn use netlink instead of rtsock from netstat: make netstat -rn use netlink instead of rtsock to [WIP] netstat: make netstat -rn use netlink instead of rtsock.
Sep 11 2022, 7:20 PM
melifaro requested review of D36529: netstat: make netstat -rn use netlink instead of rtsock.
Sep 11 2022, 7:12 PM
melifaro updated the diff for D36361: linuxolator: add netlink support.

Update to reflect netlink KPI changes.

Sep 11 2022, 6:58 PM
melifaro updated the diff for D36002: netlink: add netlink support.

Fix panic when adding vlan without id.

Sep 11 2022, 6:55 PM
melifaro retitled D36002: netlink: add netlink support from netlink: add basic netlink support to netlink: add netlink support.
Sep 11 2022, 6:54 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add (basic) link deletion/creation
  • Simplify parsing
  • Update headers
  • Sync to recent HEAD
Sep 11 2022, 6:29 PM

Sep 8 2022

melifaro committed rGe7624170772d: routing: constantify nh/nhg argument in <nhop|nhgrp>_get_origin(). (authored by melifaro).
routing: constantify nh/nhg argument in <nhop|nhgrp>_get_origin().
Sep 8 2022, 10:23 AM
melifaro committed rG000250be0d2d: routing: add abitity to set the protocol that installed route/nexthop. (authored by melifaro).
routing: add abitity to set the protocol that installed route/nexthop.
Sep 8 2022, 9:20 AM

Sep 5 2022

melifaro added inline comments to D36454: net: add pfil_run_hooks_{in,out}.
Sep 5 2022, 9:29 PM
melifaro added inline comments to D36454: net: add pfil_run_hooks_{in,out}.
Sep 5 2022, 8:40 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Fix (eventual) panic on module reload by deregistering neigh eventhandler
Sep 5 2022, 1:32 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Retire event bridge logic in favor of direct rtsock<>netlink calls
  • Add neighbor notifications
  • Update to latest -HEAD
Sep 5 2022, 1:06 PM
melifaro committed rGdb98b4205093: netinet6: call lle_event eventhandler after updating state (authored by melifaro).
netinet6: call lle_event eventhandler after updating state
Sep 5 2022, 1:02 PM
melifaro committed rG4bccbf03d81b: routing: allow logging framework to be used outside of the subsystem (authored by melifaro).
routing: allow logging framework to be used outside of the subsystem
Sep 5 2022, 10:47 AM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Provide notifications for generic netlink families load/unload
Sep 5 2022, 10:29 AM

Sep 4 2022

melifaro updated the summary of D36002: netlink: add netlink support.
Sep 4 2022, 8:27 PM
melifaro updated the diff for D36361: linuxolator: add netlink support.

Update to recent -HEAD.

Sep 4 2022, 8:22 PM
melifaro retitled D36002: netlink: add netlink support from [WIP] netlink: add basic netlink support to netlink: add basic netlink support.
Sep 4 2022, 8:20 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add generic netlink support
  • Simplify error checking when writing attributes
  • Add extended ACK support (text error messages & error offset)
Sep 4 2022, 8:14 PM

Aug 30 2022

melifaro updated the diff for D36002: netlink: add netlink support.

Address most of glebius@ comments.

Aug 30 2022, 4:44 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add support for multipath operations w/o user nexthops.
  • Generalise parsing a bit
Aug 30 2022, 4:31 PM

Aug 29 2022

melifaro updated the test plan for D36002: netlink: add netlink support.
Aug 29 2022, 6:41 PM
melifaro updated the summary of D36002: netlink: add netlink support.
Aug 29 2022, 6:32 PM
melifaro updated the diff for D36002: netlink: add netlink support.
  • Add netlink -> rtsock route event translation
  • Sync to recent HEAD
Aug 29 2022, 6:28 PM
melifaro committed rG177f04d57fbd: routing: constantify @rc in rib_decompose_notification(). (authored by melifaro).
routing: constantify @rc in rib_decompose_notification().
Aug 29 2022, 6:13 PM
melifaro added a reverting change for D36166: routing: install prefix and loopback routes using new nhop-based KPI.: rG7b3440fc3007: Revert "routing: install prefix and loopback routes using new nhop-based KPI.".
Aug 29 2022, 4:23 PM
melifaro added a reverting change for rGa1b59379db7d: routing: install prefix and loopback routes using new nhop-based KPI.: rG7b3440fc3007: Revert "routing: install prefix and loopback routes using new nhop-based KPI.".
Aug 29 2022, 4:23 PM
melifaro committed rG7b3440fc3007: Revert "routing: install prefix and loopback routes using new nhop-based KPI." (authored by melifaro).
Revert "routing: install prefix and loopback routes using new nhop-based KPI."
Aug 29 2022, 4:23 PM