Page MenuHomeFreeBSD

if_clone: migrate some consumers to the new KPI

Authored by melifaro on Sep 20 2022, 2:52 PM.
Referenced Files
Unknown Object (File)
Feb 12 2023, 5:23 PM
Unknown Object (File)
Jan 13 2023, 1:15 AM
Unknown Object (File)
Dec 25 2022, 10:01 PM
Unknown Object (File)
Dec 15 2022, 7:56 PM
Unknown Object (File)
Nov 28 2022, 9:50 PM

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

LGTM, at least for bridge, epair, ovpn, vlan and pflog.

stf panics during its test.


I think we're forgetting *ifpp = ifp; here.

I see this panic:

login: panic: Assertion *ifpp != NULL failed at /usr/src/sys/net/if_clone.c:263
cpuid = 10
time = 1663762123
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe015f2eea20
vpanic() at vpanic+0x151/frame 0xfffffe015f2eea70
panic() at panic+0x43/frame 0xfffffe015f2eead0
if_clone_createif() at if_clone_createif+0x24e/frame 0xfffffe015f2eeb20
ifc_create_ifp() at ifc_create_ifp+0xe2/frame 0xfffffe015f2eeb80
if_clone_create() at if_clone_create+0x34/frame 0xfffffe015f2eebd0
ifioctl() at ifioctl+0x92b/frame 0xfffffe015f2eecc0
kern_ioctl() at kern_ioctl+0x202/frame 0xfffffe015f2eed30
sys_ioctl() at sys_ioctl+0x12a/frame 0xfffffe015f2eee00
amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe015f2eef30
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe015f2eef30
--- syscall (54, FreeBSD ELF64, sys_ioctl), rip = 0x3336352ab7aa, rsp = 0x33362fd09528, rbp = 0x33362fd09540 ---
KDB: enter: panic
This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.
melifaro added inline comments.

Indeed, thank you!